From ae109cd653ca4bb4eb3101b7a6d13521dbe5176f Mon Sep 17 00:00:00 2001
From: KevinBKozan <kkozan@magento.com>
Date: Wed, 18 Jul 2018 11:34:18 -0500
Subject: [PATCH 1/2] Turning off all logging for Readiness Extension

- Causing jenkins failures
---
 .../Extension/PageReadinessExtension.php                  | 2 +-
 .../Extension/ReadinessMetrics/AbstractMetricCheck.php    | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/Magento/FunctionalTestingFramework/Extension/PageReadinessExtension.php b/src/Magento/FunctionalTestingFramework/Extension/PageReadinessExtension.php
index 393d03644..45ed651f1 100644
--- a/src/Magento/FunctionalTestingFramework/Extension/PageReadinessExtension.php
+++ b/src/Magento/FunctionalTestingFramework/Extension/PageReadinessExtension.php
@@ -264,7 +264,7 @@ private function logDebug($message, $context = [])
                 $logContext[$metric->getName() . '.failCount'] = $metric->getFailureCount();
             }
             $context = array_merge($logContext, $context);
-            $this->logger->info($message, $context);
+            //$this->logger->info($message, $context);
         }
     }
 }
diff --git a/src/Magento/FunctionalTestingFramework/Extension/ReadinessMetrics/AbstractMetricCheck.php b/src/Magento/FunctionalTestingFramework/Extension/ReadinessMetrics/AbstractMetricCheck.php
index c5dd7891b..c78d2ab6f 100644
--- a/src/Magento/FunctionalTestingFramework/Extension/ReadinessMetrics/AbstractMetricCheck.php
+++ b/src/Magento/FunctionalTestingFramework/Extension/ReadinessMetrics/AbstractMetricCheck.php
@@ -248,7 +248,7 @@ private function getCurrentValue($refresh = false)
      */
     public function getStoredValue()
     {
-        return $this->storedValue;
+        return $this->storedValue ?? null;
     }
 
     /**
@@ -310,7 +310,7 @@ public function resetTracker()
     protected function errorLog($message, $context = [])
     {
         $context = array_merge($this->getLogContext(), $context);
-        $this->logger->error($message, $context);
+        //$this->logger->error($message, $context);
     }
 
     /**
@@ -323,7 +323,7 @@ protected function errorLog($message, $context = [])
     protected function infoLog($message, $context = [])
     {
         $context = array_merge($this->getLogContext(), $context);
-        $this->logger->info($message, $context);
+        //$this->logger->info($message, $context);
     }
 
     /**
@@ -337,7 +337,7 @@ protected function debugLog($message, $context = [])
     {
         if ($this->verbose) {
             $context = array_merge($this->getLogContext(), $context);
-            $this->logger->debug($message, $context);
+            //$this->logger->debug($message, $context);
         }
     }
 

From d5348a0efaa5925f11a90abe9255a20e04e61d25 Mon Sep 17 00:00:00 2001
From: KevinBKozan <kkozan@magento.com>
Date: Wed, 18 Jul 2018 15:15:55 -0500
Subject: [PATCH 2/2] MQE-1147: Turning off all logging for Readiness Extension

- PHPMD fixes
---
 .../Extension/PageReadinessExtension.php                    | 2 ++
 .../Extension/ReadinessMetrics/AbstractMetricCheck.php      | 6 ++++++
 2 files changed, 8 insertions(+)

diff --git a/src/Magento/FunctionalTestingFramework/Extension/PageReadinessExtension.php b/src/Magento/FunctionalTestingFramework/Extension/PageReadinessExtension.php
index 45ed651f1..9b9163a0a 100644
--- a/src/Magento/FunctionalTestingFramework/Extension/PageReadinessExtension.php
+++ b/src/Magento/FunctionalTestingFramework/Extension/PageReadinessExtension.php
@@ -251,6 +251,7 @@ private function shouldSkipCheck($step)
      * @param string $message
      * @param array  $context
      * @return void
+     * @SuppressWarnings(PHPMD)
      */
     private function logDebug($message, $context = [])
     {
@@ -264,6 +265,7 @@ private function logDebug($message, $context = [])
                 $logContext[$metric->getName() . '.failCount'] = $metric->getFailureCount();
             }
             $context = array_merge($logContext, $context);
+            //TODO REMOVE THIS LINE, UNCOMMENT LOGGER
             //$this->logger->info($message, $context);
         }
     }
diff --git a/src/Magento/FunctionalTestingFramework/Extension/ReadinessMetrics/AbstractMetricCheck.php b/src/Magento/FunctionalTestingFramework/Extension/ReadinessMetrics/AbstractMetricCheck.php
index c78d2ab6f..417ae336f 100644
--- a/src/Magento/FunctionalTestingFramework/Extension/ReadinessMetrics/AbstractMetricCheck.php
+++ b/src/Magento/FunctionalTestingFramework/Extension/ReadinessMetrics/AbstractMetricCheck.php
@@ -306,10 +306,12 @@ public function resetTracker()
      * @param string $message
      * @param array  $context
      * @return void
+     * @SuppressWarnings(PHPMD)
      */
     protected function errorLog($message, $context = [])
     {
         $context = array_merge($this->getLogContext(), $context);
+        //TODO REMOVE THIS LINE, UNCOMMENT LOGGER
         //$this->logger->error($message, $context);
     }
 
@@ -319,10 +321,12 @@ protected function errorLog($message, $context = [])
      * @param string $message
      * @param array  $context
      * @return void
+     * @SuppressWarnings(PHPMD)
      */
     protected function infoLog($message, $context = [])
     {
         $context = array_merge($this->getLogContext(), $context);
+        //TODO REMOVE THIS LINE, UNCOMMENT LOGGER
         //$this->logger->info($message, $context);
     }
 
@@ -332,11 +336,13 @@ protected function infoLog($message, $context = [])
      * @param string $message
      * @param array  $context
      * @return void
+     * @SuppressWarnings(PHPMD)
      */
     protected function debugLog($message, $context = [])
     {
         if ($this->verbose) {
             $context = array_merge($this->getLogContext(), $context);
+            //TODO REMOVE THIS LINE, UNCOMMENT LOGGER
             //$this->logger->debug($message, $context);
         }
     }