Skip to content

Commit e51d4af

Browse files
authored
MQE-842: Update feature and story tags to map to test functions when generated
- Stories/Features now generate at function level, not class level. - updated verification tests
1 parent 7014ea6 commit e51d4af

13 files changed

+48
-47
lines changed

dev/tests/verification/Resources/ActionGroupWithDataOverrideTest.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ use Yandex\Allure\Adapter\Annotation\TestCaseId;
1818
/**
1919
* @Title("A Functional Cest")
2020
* @group functional
21-
* @Features({"Action Group Functional Cest"})
22-
* @Stories({"MQE-433"})
2321
*/
2422
class ActionGroupWithDataOverrideTestCest
2523
{
@@ -64,6 +62,8 @@ class ActionGroupWithDataOverrideTestCest
6462

6563
/**
6664
* @Severity(level = SeverityLevel::CRITICAL)
65+
* @Features({"Action Group Functional Cest"})
66+
* @Stories({"MQE-433"})
6767
* @Parameter(name = "AcceptanceTester", value="$I")
6868
* @param AcceptanceTester $I
6969
* @return void

dev/tests/verification/Resources/ActionGroupWithDataTest.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ use Yandex\Allure\Adapter\Annotation\TestCaseId;
1818
/**
1919
* @Title("A Functional Cest")
2020
* @group functional
21-
* @Features({"Action Group Functional Cest"})
22-
* @Stories({"MQE-433"})
2321
*/
2422
class ActionGroupWithDataTestCest
2523
{
@@ -64,6 +62,8 @@ class ActionGroupWithDataTestCest
6462

6563
/**
6664
* @Severity(level = SeverityLevel::CRITICAL)
65+
* @Features({"Action Group Functional Cest"})
66+
* @Stories({"MQE-433"})
6767
* @Parameter(name = "AcceptanceTester", value="$I")
6868
* @param AcceptanceTester $I
6969
* @return void

dev/tests/verification/Resources/ActionGroupWithNoDefaultTest.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ use Yandex\Allure\Adapter\Annotation\TestCaseId;
1818
/**
1919
* @Title("A Functional Cest")
2020
* @group functional
21-
* @Features({"Action Group Functional Cest"})
22-
* @Stories({"MQE-433"})
2321
*/
2422
class ActionGroupWithNoDefaultTestCest
2523
{
@@ -64,6 +62,8 @@ class ActionGroupWithNoDefaultTestCest
6462

6563
/**
6664
* @Severity(level = SeverityLevel::CRITICAL)
65+
* @Features({"Action Group Functional Cest"})
66+
* @Stories({"MQE-433"})
6767
* @Parameter(name = "AcceptanceTester", value="$I")
6868
* @param AcceptanceTester $I
6969
* @return void

dev/tests/verification/Resources/ActionGroupWithPersistedData.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ use Yandex\Allure\Adapter\Annotation\TestCaseId;
1818
/**
1919
* @Title("A Functional Cest")
2020
* @group functional
21-
* @Features({"Action Group Functional Cest"})
22-
* @Stories({"MQE-433"})
2321
*/
2422
class ActionGroupWithPersistedDataCest
2523
{
@@ -64,6 +62,8 @@ class ActionGroupWithPersistedDataCest
6462

6563
/**
6664
* @Severity(level = SeverityLevel::CRITICAL)
65+
* @Features({"Action Group Functional Cest"})
66+
* @Stories({"MQE-433"})
6767
* @Parameter(name = "AcceptanceTester", value="$I")
6868
* @param AcceptanceTester $I
6969
* @return void

dev/tests/verification/Resources/ActionGroupWithTopLevelPersistedData.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ use Yandex\Allure\Adapter\Annotation\TestCaseId;
1818
/**
1919
* @Title("A Functional Cest")
2020
* @group functional
21-
* @Features({"Action Group Functional Cest"})
22-
* @Stories({"MQE-433"})
2321
*/
2422
class ActionGroupWithTopLevelPersistedDataCest
2523
{
@@ -64,6 +62,8 @@ class ActionGroupWithTopLevelPersistedDataCest
6462

6563
/**
6664
* @Severity(level = SeverityLevel::CRITICAL)
65+
* @Features({"Action Group Functional Cest"})
66+
* @Stories({"MQE-433"})
6767
* @Parameter(name = "AcceptanceTester", value="$I")
6868
* @param AcceptanceTester $I
6969
* @return void

dev/tests/verification/Resources/ArgumentWithSameNameAsElement.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ use Yandex\Allure\Adapter\Annotation\TestCaseId;
1818
/**
1919
* @Title("A Functional Cest")
2020
* @group functional
21-
* @Features({"Action Group Functional Cest"})
22-
* @Stories({"MQE-433"})
2321
*/
2422
class ArgumentWithSameNameAsElementCest
2523
{
@@ -64,6 +62,8 @@ class ArgumentWithSameNameAsElementCest
6462

6563
/**
6664
* @Severity(level = SeverityLevel::CRITICAL)
65+
* @Features({"Action Group Functional Cest"})
66+
* @Stories({"MQE-433"})
6767
* @Parameter(name = "AcceptanceTester", value="$I")
6868
* @param AcceptanceTester $I
6969
* @return void

dev/tests/verification/Resources/BasicActionGroupTest.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ use Yandex\Allure\Adapter\Annotation\TestCaseId;
1818
/**
1919
* @Title("A Functional Cest")
2020
* @group functional
21-
* @Features({"Action Group Functional Cest"})
22-
* @Stories({"MQE-433"})
2321
*/
2422
class BasicActionGroupTestCest
2523
{
@@ -44,6 +42,8 @@ class BasicActionGroupTestCest
4442

4543
/**
4644
* @Severity(level = SeverityLevel::CRITICAL)
45+
* @Features({"Action Group Functional Cest"})
46+
* @Stories({"MQE-433"})
4747
* @Parameter(name = "AcceptanceTester", value="$I")
4848
* @param AcceptanceTester $I
4949
* @return void

dev/tests/verification/Resources/BasicFunctionalTest.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ use Yandex\Allure\Adapter\Annotation\TestCaseId;
1818
/**
1919
* @Title("A Functional Cest")
2020
* @group functional
21-
* @Features({"Basic Functional Cest"})
22-
* @Stories({"MQE-305"})
2321
*/
2422
class BasicFunctionalTestCest
2523
{
@@ -53,6 +51,8 @@ class BasicFunctionalTestCest
5351

5452
/**
5553
* @Severity(level = SeverityLevel::CRITICAL)
54+
* @Features({"Basic Functional Cest"})
55+
* @Stories({"MQE-305"})
5656
* @Parameter(name = "AcceptanceTester", value="$I")
5757
* @param AcceptanceTester $I
5858
* @return void

dev/tests/verification/Resources/BasicMergeTest.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ use Yandex\Allure\Adapter\Annotation\TestCaseId;
1919
* @Title("A Functional Cest")
2020
* @group functional
2121
* @group mergeTest
22-
* @Features({"Merge Functional Cest"})
23-
* @Stories({"MQE-433"})
2422
*/
2523
class BasicMergeTestCest
2624
{
@@ -55,6 +53,8 @@ class BasicMergeTestCest
5553

5654
/**
5755
* @Severity(level = SeverityLevel::CRITICAL)
56+
* @Features({"Merge Functional Cest"})
57+
* @Stories({"MQE-433"})
5858
* @Parameter(name = "AcceptanceTester", value="$I")
5959
* @param AcceptanceTester $I
6060
* @return void

dev/tests/verification/Resources/MergedActionGroupTest.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ use Yandex\Allure\Adapter\Annotation\TestCaseId;
1818
/**
1919
* @Title("A Functional Cest")
2020
* @group functional
21-
* @Features({"Action Group Functional Cest"})
22-
* @Stories({"MQE-433"})
2321
*/
2422
class MergedActionGroupTestCest
2523
{
@@ -64,6 +62,8 @@ class MergedActionGroupTestCest
6462

6563
/**
6664
* @Severity(level = SeverityLevel::CRITICAL)
65+
* @Features({"Action Group Functional Cest"})
66+
* @Stories({"MQE-433"})
6767
* @Parameter(name = "AcceptanceTester", value="$I")
6868
* @param AcceptanceTester $I
6969
* @return void

dev/tests/verification/Resources/MergedReferencesTest.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ use Yandex\Allure\Adapter\Annotation\TestCaseId;
1818
/**
1919
* @Title("A Functional Cest")
2020
* @group functional
21-
* @Features({"Merge Functional Cest"})
22-
* @Stories({"MQE-433"})
2321
*/
2422
class MergedReferencesTestCest
2523
{
@@ -53,6 +51,8 @@ class MergedReferencesTestCest
5351

5452
/**
5553
* @Severity(level = SeverityLevel::CRITICAL)
54+
* @Features({"Merge Functional Cest"})
55+
* @Stories({"MQE-433"})
5656
* @Parameter(name = "AcceptanceTester", value="$I")
5757
* @param AcceptanceTester $I
5858
* @return void

dev/tests/verification/Resources/MultipleActionGroupsTest.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ use Yandex\Allure\Adapter\Annotation\TestCaseId;
1818
/**
1919
* @Title("A Functional Cest")
2020
* @group functional
21-
* @Features({"Action Group Functional Cest"})
22-
* @Stories({"MQE-433"})
2321
*/
2422
class MultipleActionGroupsTestCest
2523
{
@@ -64,6 +62,8 @@ class MultipleActionGroupsTestCest
6462

6563
/**
6664
* @Severity(level = SeverityLevel::CRITICAL)
65+
* @Features({"Action Group Functional Cest"})
66+
* @Stories({"MQE-433"})
6767
* @Parameter(name = "AcceptanceTester", value="$I")
6868
* @param AcceptanceTester $I
6969
* @return void

src/Magento/FunctionalTestingFramework/Util/TestGenerator.php

Lines changed: 24 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -295,6 +295,30 @@ private function generateMethodAnnotations($annotationType = null, $annotationNa
295295
$indent = "\t";
296296

297297
switch ($annotationType) {
298+
case "features":
299+
$features = "";
300+
foreach ($annotationName as $name) {
301+
$features .= sprintf("\"%s\"", $name);
302+
303+
if (next($annotationName)) {
304+
$features .= ", ";
305+
}
306+
}
307+
$annotationToAppend .= sprintf("{$indent} * @Features({%s})\n", $features);
308+
break;
309+
310+
case "stories":
311+
$stories = "";
312+
foreach ($annotationName as $name) {
313+
$stories .= sprintf("\"%s\"", $name);
314+
315+
if (next($annotationName)) {
316+
$stories .= ", ";
317+
}
318+
}
319+
$annotationToAppend .= sprintf("{$indent} * @Stories({%s})\n", $stories);
320+
break;
321+
298322
case "severity":
299323
$annotationToAppend = sprintf("{$indent} * @Severity(level = SeverityLevel::%s)\n", $annotationName[0]);
300324
break;
@@ -327,29 +351,6 @@ private function generateClassAnnotations($annotationType, $annotationName)
327351
$annotationToAppend = null;
328352

329353
switch ($annotationType) {
330-
case "features":
331-
$features = "";
332-
foreach ($annotationName as $name) {
333-
$features .= sprintf("\"%s\"", $name);
334-
335-
if (next($annotationName)) {
336-
$features .= ", ";
337-
}
338-
}
339-
$annotationToAppend .= sprintf(" * @Features({%s})\n", $features);
340-
break;
341-
342-
case "stories":
343-
$stories = "";
344-
foreach ($annotationName as $name) {
345-
$stories .= sprintf("\"%s\"", $name);
346-
347-
if (next($annotationName)) {
348-
$stories .= ", ";
349-
}
350-
}
351-
$annotationToAppend .= sprintf(" * @Stories({%s})\n", $stories);
352-
break;
353354

354355
case "title":
355356
$annotationToAppend = sprintf(" * @Title(\"%s\")\n", $annotationName[0]);

0 commit comments

Comments
 (0)