Skip to content

Commit e2d5059

Browse files
committed
MQE-677: Unable to use integer "0" as data in an entity
- perform expcliity null check on replacement var
1 parent 6d0871e commit e2d5059

File tree

4 files changed

+5
-1
lines changed

4 files changed

+5
-1
lines changed

dev/tests/verification/Resources/DataReplacementTest.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,5 +46,6 @@ class DataReplacementTestCest
4646
$I->amOnUrl("Doe".msq("uniqueData").".html");
4747
$I->searchAndMultiSelectOption("#selector", ["John", "Doe".msq("uniqueData")]);
4848
$I->searchAndMultiSelectOption("#selector", [msq("uniqueData")."John", "Doe".msq("uniqueData")]);
49+
$I->fillField(".selector", "0");
4950
}
5051
}

dev/tests/verification/TestModule/Data/ReplacementData.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
<data key="firstname">John</data>
1414
<data key="lastname">Doe</data>
1515
<data key="middlename">Tiberius</data>
16+
<data key="favoriteIndex">0</data>
1617
</entity>
1718
<entity name="uniqueData" type="simpleData">
1819
<data key="firstname" unique="prefix">John</data>

dev/tests/verification/TestModule/Test/DataReplacementTest.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,5 +30,7 @@
3030
<amOnUrl stepKey="urlReplaceMSQSuffix" url="{{uniqueData.lastname}}.html"/>
3131
<searchAndMultiSelectOption stepKey="parameterArrayReplacementMSQSuffix" selector="#selector" parameterArray="[{{simpleData.firstname}}, {{uniqueData.lastname}}]"/>
3232
<searchAndMultiSelectOption stepKey="parameterArrayReplacementMSQBoth" selector="#selector" parameterArray="[{{uniqueData.firstname}}, {{uniqueData.lastname}}]"/>
33+
34+
<fillField stepKey="insertZero" selector=".selector" userInput="{{simpleData.favoriteIndex}}"/>
3335
</test>
3436
</tests>

src/Magento/FunctionalTestingFramework/Test/Objects/ActionObject.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ private function resolveDataInputReferences()
312312
foreach ($relevantDataAttributes as $dataAttribute) {
313313
$varInput = $this->actionAttributes[$dataAttribute];
314314
$replacement = $this->findAndReplaceReferences(DataObjectHandler::getInstance(), $varInput);
315-
if ($replacement) {
315+
if ($replacement != null) {
316316
$this->resolvedCustomAttributes[$dataAttribute] = $replacement;
317317
}
318318
}

0 commit comments

Comments
 (0)