Skip to content

Commit d1dc19e

Browse files
committed
MQE-574: set proper required attributes in test schema and added attribute rule checks in test generator.
1 parent 1632842 commit d1dc19e

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

dev/tests/verification/TestModule/Cest/BasicFunctionalCest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
<grabValueFrom returnVariable="someVar" stepKey="someVarDefinition"/>
3434
<acceptPopup stepKey="acceptPopupKey1"/>
3535
<amOnPage stepKey="amOnPageKey1" url="/test/url"/>
36-
<appendField variable="someVar" selector=".functionalTestSelector" userInput="someInput" stepKey="appendFieldKey1" />
36+
<appendField variable="someVar" selector=".functionalTestSelector" stepKey="appendFieldKey1" />
3737
<attachFile userInput="testFileAttachment" selector=".functionalTestSelector" stepKey="attachFileKey1" />
3838
<cancelPopup stepKey="cancelPopupKey1"/>
3939
<checkOption selector=".functionalTestSelector" stepKey="checkOptionKey1"/>
@@ -50,7 +50,7 @@
5050
<dontSeeElement selector=".functionalTestSelector" stepKey="dontSeeElementKey1"/>
5151
<dontSeeElementInDOM selector=".functionalTestSelector" stepKey="dontSeeElementInDOMKey1"/>
5252
<dontSeeInCurrentUrl url="/functionalUrl" stepKey="dontSeeInCurrentUrlKey1"/>
53-
<dontSeeInField variable="someVar" selector=".functionalTestSelector" userInput="someInput" stepKey="dontSeeInFieldKey1" />
53+
<dontSeeInField variable="someVar" selector=".functionalTestSelector" stepKey="dontSeeInFieldKey1" />
5454
<dontSeeInPageSource userInput="someInput" stepKey="dontSeeInPageSourceKey1"/>
5555
<dontSeeInSource html="&quot;&lt;myHtmlHere&gt;&quot;" stepKey="dontSeeInSourceKey1"/>
5656
<dontSeeInTitle userInput="someInput" stepKey="dontSeeInTitleKey1"/>

src/Magento/FunctionalTestingFramework/Util/TestGenerator.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1560,7 +1560,11 @@ private function validateXmlAttributesMutuallyExclusive($key, $tagName, $attribu
15601560
'url',
15611561
'userInput',
15621562
'variable',
1563-
]
1563+
],
1564+
'excludes' => [
1565+
'dontSeeLink',
1566+
'seeLink',
1567+
],
15641568
],
15651569
[
15661570
'attributes' => [

0 commit comments

Comments
 (0)