Skip to content

Commit c454c33

Browse files
committed
MQE-1919: MFTF AWS Secrets Manager - CI Use
1 parent 270cb83 commit c454c33

File tree

1 file changed

+13
-12
lines changed

1 file changed

+13
-12
lines changed

src/Magento/FunctionalTestingFramework/DataGenerator/Handlers/SecretStorage/AwsSecretsManagerStorage.php

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -115,19 +115,18 @@ public function getEncryptedValue($key)
115115
$reValue = openssl_encrypt($value, parent::ENCRYPTION_ALGO, parent::$encodedKey, 0, parent::$iv);
116116
parent::$cachedSecretData[$key] = $reValue;
117117
} catch (AwsException $e) {
118-
print_r('AwsException:' . $e->getAwsErrorMessage());
119-
$error = $e->getAwsErrorCode();
118+
$errMessage = "\nAWS Exception:\n" . $e->getAwsErrorMessage()
119+
. "\nUnable to read value for key {$key} from AWS Secrets Manager\n";
120+
print_r($errMessage);
120121
if (MftfApplicationConfig::getConfig()->verboseEnabled()) {
121-
LoggingUtil::getInstance()->getLogger(AwsSecretsManagerStorage::class)->debug(
122-
"AWS error code: {$error}. Unable to read value for key {$key} from AWS Secrets Manager"
123-
);
122+
LoggingUtil::getInstance()->getLogger(AwsSecretsManagerStorage::class)->debug($errMessage);
124123
}
125124
} catch (\Exception $e) {
126-
print_r('Exception:' . $e->getMessage());
125+
$errMessage = "\nException:\n" . $e->getMessage()
126+
. "\nUnable to read value for key {$key} from AWS Secrets Manager\n";
127+
print_r($errMessage);
127128
if (MftfApplicationConfig::getConfig()->verboseEnabled()) {
128-
LoggingUtil::getInstance()->getLogger(AwsSecretsManagerStorage::class)->debug(
129-
"Unable to read value for key {$key} from AWS Secrets Manager"
130-
);
129+
LoggingUtil::getInstance()->getLogger(AwsSecretsManagerStorage::class)->debug($errMessage);
131130
}
132131
}
133132
return $reValue;
@@ -157,10 +156,12 @@ private function parseAwsSecretResult($awsResult, $key)
157156
$secret = json_decode($rawSecret, true);
158157
if (isset($secret[$key])) {
159158
return $secret[$key];
160-
} elseif (is_string($awsResult)) {
161-
return $awsResult;
159+
} elseif (is_string($rawSecret)) {
160+
return $rawSecret;
162161
}
163-
throw new TestFrameworkException("$key not found in AWS Result. Error parsing result from AWS Secrets Manager");
162+
throw new TestFrameworkException(
163+
"$key not found or value is not string . Error parsing result from AWS Secrets Manager"
164+
);
164165
}
165166

166167
/**

0 commit comments

Comments
 (0)