Skip to content

Commit ac8d76e

Browse files
committed
MQE-683: [Deprecation] Only use more nested assertion syntax
- More fixes
1 parent e5666c1 commit ac8d76e

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/Magento/FunctionalTestingFramework/Upgrade/UpdateAssertionSchema.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,9 @@ public function execute(InputInterface $input)
4545
$fileSystem = new Filesystem();
4646
$testsUpdated = 0;
4747
foreach ($finder->files() as $file) {
48-
if (!$this->detectOldAttributes($file)) {
49-
continue;
50-
}
48+
// if (!$this->detectOldAttributes($file)) {
49+
// continue;
50+
// }
5151
$this->currentFile = $file->getFilename();
5252
$contents = $file->getContents();
5353
// Isolate <assert ... /> but not <assert> ... </assert>
@@ -157,7 +157,7 @@ private function convertOldAssertionToNew($assertion)
157157
// Massage subElements with data for edge cases
158158
if ($assertType == 'assertElementContainsAttribute') {
159159
// Assert type is very edge-cased, completely different schema
160-
$value = $subElements['expected']['value'];
160+
$value = $subElements['expected']['value'] ?? "";
161161
$selector = $trimmedParts['selector'];
162162
$attribute = $trimmedParts['attribute'];
163163
$newString .= "\t\t\t<expectedResult selector=\"$selector\" attribute=\"$attribute\">$value</expectedResult>\n";

0 commit comments

Comments
 (0)