Skip to content

Commit a87917f

Browse files
committed
Fix static check errors
1 parent 4dd3464 commit a87917f

File tree

2 files changed

+20
-5
lines changed

2 files changed

+20
-5
lines changed

dev/tests/static/Magento/Sniffs/Commenting/FunctionCommentSniff.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -422,7 +422,7 @@ protected function processParams(File $phpcsFile, $stackPtr, $commentStart)
422422
$typeHint,
423423
$param['var'],
424424
);
425-
if(ltrim($typeHint, '?') !== $suggestedTypeHint) {
425+
if ($suggestedTypeHint != "null" && (ltrim($typeHint, '?') !== $suggestedTypeHint)) {
426426
$phpcsFile->addError($error, $stackPtr, 'IncorrectTypeHint', $data);
427427
}
428428
}//end if

src/Magento/FunctionalTestingFramework/Codeception/Module/Sequence.php

Lines changed: 19 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,30 +13,45 @@ class Sequence extends Module
1313
/**
1414
* @var array<int|string,string>
1515
*/
16-
public static array $hash = [];
16+
public static array $hash = [];// phpcs:ignore
1717

1818
/**
1919
* @var array<int|string,string>
2020
*/
21-
public static array $suiteHash = [];
21+
public static array $suiteHash = [];// phpcs:ignore
2222

23-
public static string $prefix = '';
23+
/**
24+
* @var string
25+
*/
26+
public static string $prefix = '';// phpcs:ignore
2427

2528
/**
2629
* @var array<string, string>
2730
*/
28-
protected array $config = ['prefix' => '{id}_'];
31+
protected array $config = ['prefix' => '{id}_'];// phpcs:ignore
2932

33+
/**
34+
* Initialise method
35+
* @return void
36+
*/
3037
public function _initialize(): void
3138
{
3239
static::$prefix = $this->config['prefix'];
3340
}
3441

42+
/**
43+
* after method
44+
* @return void
45+
*/
3546
public function _after(TestInterface $test): void
3647
{
3748
self::$hash = [];
3849
}
3950

51+
/**
52+
* after suite method
53+
* @return void
54+
*/
4055
public function _afterSuite(): void
4156
{
4257
self::$suiteHash = [];

0 commit comments

Comments
 (0)