MQE-2104: Allure attachments don't appear in report for VERBOSE_ARTIFACTS=true for passing tests

KevinBKozan · KevinBKozan · commit 9229669083ec · 2020-04-27T12:44:18.000-05:00
- Fixed comparison to string.
diff --git a/src/Magento/FunctionalTestingFramework/Allure/Adapter/MagentoAllureAdapter.php b/src/Magento/FunctionalTestingFramework/Allure/Adapter/MagentoAllureAdapter.php
@@ -398,7 +398,7 @@ private function retrieveStepKey($stepLine)
     private function removeAttachments($step, $testFailed)
     {
         //Remove Attachments if verbose flag is not true AND test did not fail
-        if (getenv('VERBOSE_ARTIFACTS') !== true && $testFailed === null) {
+        if (getenv('VERBOSE_ARTIFACTS') !== "true" && $testFailed === null) {
             foreach ($step->getAttachments() as $index => $attachment) {
                 $step->removeAttachment($index);
                 unlink(Provider::getOutputDirectory() . DIRECTORY_SEPARATOR . $attachment->getSource());

Original file line number	Diff line number	Diff line change
`@@ -398,7 +398,7 @@ private function retrieveStepKey($stepLine)`
`398`	`398`	`private function removeAttachments($step, $testFailed)`
`399`	`399`	`{`
`400`	`400`	`//Remove Attachments if verbose flag is not true AND test did not fail`
`401`		`- if (getenv('VERBOSE_ARTIFACTS') !== true && $testFailed === null) {`
	`401`	`+ if (getenv('VERBOSE_ARTIFACTS') !== "true" && $testFailed === null) {`
`402`	`402`	`foreach ($step->getAttachments() as $index => $attachment) {`
`403`	`403`	`$step->removeAttachment($index);`
`404`	`404`	`unlink(Provider::getOutputDirectory() . DIRECTORY_SEPARATOR . $attachment->getSource());`