Skip to content

Commit 839377e

Browse files
authored
Fix ModuleResolver windows compatibility
- Fixed windows compatibility for Magento Module registration fetching.
1 parent a9e04a7 commit 839377e

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ Magento Functional Testing Framework Changelog
99

1010
### Fixes
1111
* Fixed an issue where mftf would fail to parse test materials for extensions installed under `vendor`.
12+
* Fixed a Windows compatibility issue around the use of Magento's `ComponentRegistrar` to aggregate paths.
1213
* Fixed an issue where an `element` with no `type` would cause PHP warnings during test runs.
1314

1415
2.3.9

src/Magento/FunctionalTestingFramework/Util/ModuleResolver.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -553,7 +553,9 @@ private function getRegisteredModuleList()
553553
$allComponents = array_merge($allComponents, $components->getPaths($componentType));
554554
}
555555
array_walk($allComponents, function (&$value) {
556-
$value .= DIRECTORY_SEPARATOR . 'Test' . DIRECTORY_SEPARATOR . 'Mftf';
556+
// Magento stores component paths with unix DIRECTORY_SEPARATOR, need to stay uniform and convert
557+
$value .= '/Test/Mftf';
558+
$value = realpath($value);
557559
});
558560
return $allComponents;
559561
} catch (TestFrameworkException $e) {

0 commit comments

Comments
 (0)