Skip to content

Commit 6994ad9

Browse files
Manjusha.SManjusha.S
Manjusha.S
authored and
Manjusha.S
committed
2 parents a81144d + 7fb664f commit 6994ad9

File tree

3 files changed

+22
-4
lines changed

3 files changed

+22
-4
lines changed

CHANGELOG.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,19 @@
11
Magento Functional Testing Framework Changelog
22
================================================
33

4+
3.11.0
5+
---------
6+
### Enhancements
7+
* Composer updated to 2.4.2 version
8+
* Static check for duplicate step keys in action group
9+
10+
11+
### Fixes
12+
13+
* Fixed incorrect MFTF test dependencies path
14+
* Removed PHP 7.3 build check from MFTF PR build as PHP 7.3 is no longer supported
15+
16+
417
3.10.3
518
---------
619

composer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "magento/magento2-functional-testing-framework",
33
"description": "Magento2 Functional Testing Framework",
44
"type": "library",
5-
"version": "3.10.3",
5+
"version": "3.11.0",
66
"license": "AGPL-3.0",
77
"keywords": ["magento", "automation", "functional", "testing"],
88
"config": {
@@ -22,7 +22,7 @@
2222
"codeception/module-asserts": "^1.1",
2323
"codeception/module-sequence": "^1.0",
2424
"codeception/module-webdriver": "^1.0",
25-
"composer/composer": "^1.9 || ^2.0, !=2.2.16",
25+
"composer/composer": "^2.0, !=2.2.16",
2626
"csharpru/vault-php": "^4.2.1",
2727
"guzzlehttp/guzzle": "^7.3.0",
2828
"laminas/laminas-diactoros": "^2.8",

src/Magento/FunctionalTestingFramework/StaticCheck/ActionGroupStandardsCheck.php

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,11 @@ private function findErrorsInFileSet($files)
103103
$actionGroupReferencesDataArray = [];
104104
$actionGroupToArguments = [];
105105
$contents = $filePath->getContents();
106-
preg_match_all(self::STEP_KEY_REGEX_PATTERN, $contents, $actionGroupReferences);
106+
preg_match_all(
107+
self::STEP_KEY_REGEX_PATTERN,
108+
preg_replace('/<!--(.|\s)*?-->/', '', $contents),
109+
$actionGroupReferences
110+
);
107111
foreach ($actionGroupReferences[0] as $actionGroupReferencesData) {
108112
$actionGroupReferencesDataArray[] = trim(
109113
str_replace(['stepKey', '='], [""], $actionGroupReferencesData)
@@ -119,7 +123,8 @@ private function findErrorsInFileSet($files)
119123
);
120124
unset($actionGroupReferencesDataArray);
121125
if (isset($duplicateStepKeys) && count($duplicateStepKeys) > 0) {
122-
throw new TestFrameworkException('Action group has duplicate step keys');
126+
throw new TestFrameworkException('Action group has duplicate step keys '
127+
.implode(",", array_unique($duplicateStepKeys))." File Path ".$filePath);
123128
}
124129
/** @var DOMElement $actionGroup */
125130
$actionGroup = $this->getActionGroupDomElement($contents);

0 commit comments

Comments
 (0)