Merge pull request #573 from lbajsarowicz/fix/magentocron-no-group-provided

okolesnyk · web-flow · commit 3ccf894ca210 · 2020-02-04T17:16:38.000-05:00
Quick Fix: PHP's max() requires at least 1 argument
diff --git a/src/Magento/FunctionalTestingFramework/Module/MagentoWebDriver.php b/src/Magento/FunctionalTestingFramework/Module/MagentoWebDriver.php
@@ -601,6 +601,10 @@ private function notifyCronFinished(array $cronGroups = [])
      */
     private function getLastCronExecution(array $cronGroups = [])
     {
+        if (empty($this->cronExecution)) {
+            return 0;
+        }
+
         if (empty($cronGroups)) {
             return (int)max($this->cronExecution);
         }
@@ -1060,7 +1064,7 @@ public function getSecret($key)
     /**
      * Waits proper amount of time to perform Cron execution
      *
-     * @param string  $cronGroups
+     * @param array   $cronGroups
      * @param integer $timeout
      * @param string  $arguments
      * @return string

Original file line number	Diff line number	Diff line change
`@@ -601,6 +601,10 @@ private function notifyCronFinished(array $cronGroups = [])`
`601`	`601`	`*/`
`602`	`602`	`private function getLastCronExecution(array $cronGroups = [])`
`603`	`603`	`{`
	`604`	`+ if (empty($this->cronExecution)) {`
	`605`	`+ return 0;`
	`606`	`+ }`
	`607`	`+`
`604`	`608`	`if (empty($cronGroups)) {`
`605`	`609`	`return (int)max($this->cronExecution);`
`606`	`610`	`}`
`@@ -1060,7 +1064,7 @@ public function getSecret($key)`
`1060`	`1064`	`/**`
`1061`	`1065`	`* Waits proper amount of time to perform Cron execution`
`1062`	`1066`	`*`
`1063`		`- * @param string $cronGroups`
	`1067`	`+ * @param array $cronGroups`
`1064`	`1068`	`* @param integer $timeout`
`1065`	`1069`	`* @param string $arguments`
`1066`	`1070`	`* @return string`