MQE-1288: ModuleResolver test paths are too greedy

KevinBKozan · KevinBKozan · commit 3845479cbe58 · 2018-10-05T08:54:12.000-05:00
- test dom.php fix for filename
diff --git a/src/Magento/FunctionalTestingFramework/Test/Config/Dom.php b/src/Magento/FunctionalTestingFramework/Test/Config/Dom.php
@@ -88,7 +88,8 @@ public function initDom($xml, $filename = null)
     {
         $dom = parent::initDom($xml, $filename);
 
-        if ($this->checkFilenameSuffix($filename, self::TEST_FILE_NAME_ENDING)) {
+        // Cannot rely on filename to ensure this file is a Test.xml
+        if ($dom->getElementsByTagName('tests')->length > 0) {
             $testsNode = $dom->getElementsByTagName('tests')[0];
             $testNodes = $dom->getElementsByTagName('test');
             $this->testsValidationUtil->validateChildUniqueness(

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,8 @@ public function initDom($xml, $filename = null)`
`88`	`88`	`{`
`89`	`89`	`$dom = parent::initDom($xml, $filename);`
`90`	`90`
`91`		`- if ($this->checkFilenameSuffix($filename, self::TEST_FILE_NAME_ENDING)) {`
	`91`	`+ // Cannot rely on filename to ensure this file is a Test.xml`
	`92`	`+ if ($dom->getElementsByTagName('tests')->length > 0) {`
`92`	`93`	`$testsNode = $dom->getElementsByTagName('tests')[0];`
`93`	`94`	`$testNodes = $dom->getElementsByTagName('test');`
`94`	`95`	`$this->testsValidationUtil->validateChildUniqueness(`