Skip to content

Commit 283d63b

Browse files
jilu1soumyau
authored andcommitted
MQE-2138: annotation static check incorrectly flags some extends tests for missing issueIds
1 parent 3804ddd commit 283d63b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/Magento/FunctionalTestingFramework/StaticCheck/AnnotationsCheck.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,8 +163,8 @@ private function validateSkipIssueId($test)
163163
$skip = $annotations['skip'] ?? null;
164164
if ($skip !== null) {
165165
$validateSkipped = true;
166-
$issueId = $skip[0] ?? null;
167-
if ($issueId === null || strlen($issueId) == 0) {
166+
if ((!isset($skip[0]) || strlen($skip[0]) == 0)
167+
&& (!isset($skip['issueId']) || strlen($skip['issueId']) == 0)) {
168168
$this->errors[][] = "Test {$test->getName()} is skipped but the issueId is empty.";
169169
}
170170
}

0 commit comments

Comments
 (0)