MQE-1043: MFTF force flag should ignore the magento base url even when valid

- Unit test updates to maintain coverage.

Author: KevinBKozan

dev/tests/unit/Magento/FunctionalTestFramework/Util/ModuleResolverTest.php

@@ -56,9 +56,10 @@ public function testGetModulePathsAlreadySet()
      */
     public function testGetModulePathsAggregate()
     {
-        $this->setMockResolverClass(false, null, null, null, ["example" . DIRECTORY_SEPARATOR . "paths"]);
+        $this->mockForceGenerate(false);
+        $this->setMockResolverClass(false, null, null, null, ["example" => "example" . DIRECTORY_SEPARATOR . "paths"]);
         $resolver = ModuleResolver::getInstance();
-        $this->setMockResolverProperties($resolver, null, null);
+        $this->setMockResolverProperties($resolver, null, [0 => "Magento_example"]);
         $this->assertEquals(
             [
                 "example" . DIRECTORY_SEPARATOR . "paths",
@@ -75,12 +76,13 @@ public function testGetModulePathsAggregate()
      */
     public function testGetModulePathsLocations()
     {
+        $this->mockForceGenerate(false);
         $mockResolver = $this->setMockResolverClass(
-            false,
-            null,
+            true,
+            [0 => "magento_example"],
             null,
             null,
-            ["example" . DIRECTORY_SEPARATOR . "paths"]
+            ["example" => "example" . DIRECTORY_SEPARATOR . "paths"]
         );
         $resolver = ModuleResolver::getInstance();
         $this->setMockResolverProperties($resolver, null, null);
@@ -205,6 +207,43 @@ public function testGetAdminTokenNotCalledWhenForce()
         $this->addToAssertionCount(1);
     }
 
+    /**
+     * Verify the getAdminToken method returns throws an exception if ENV is not fully loaded.
+     */
+    public function testGetAdminTokenWithMissingEnv()
+    {
+        // Set --force to true
+        $this->mockForceGenerate(false);
+
+        // Unset env
+        unset($_ENV['MAGENTO_ADMIN_USERNAME']);
+
+        // Mock ModuleResolver and applyCustomModuleMethods()
+        $mockResolver = $this->setMockResolverClass();
+        $resolver = ModuleResolver::getInstance();
+
+        // Expect exception
+        $this->expectException(TestFrameworkException::class);
+        $resolver->getModulesPath();
+    }
+
+    /**
+     * Verify the getAdminToken method returns throws an exception if Token was bad.
+     */
+    public function testGetAdminTokenWithBadResponse()
+    {
+        // Set --force to true
+        $this->mockForceGenerate(false);
+
+        // Mock ModuleResolver and applyCustomModuleMethods()
+        $mockResolver = $this->setMockResolverClass();
+        $resolver = ModuleResolver::getInstance();
+
+        // Expect exception
+        $this->expectException(TestFrameworkException::class);
+        $resolver->getModulesPath();
+    }
+
     /**
      * Function used to set mock for parser return and force init method to run between tests.
      *
@@ -233,7 +272,7 @@ private function setMockResolverClass(
         if (isset($mockToken)) {
             $mockMethods['getAdminToken'] = $mockToken;
         }
-        if (isset($mockModules)) {
+        if (isset($mockGetModules)) {
             $mockMethods['getEnabledModules'] = $mockGetModules;
         }
         if (isset($mockCustomMethods)) {
@@ -248,7 +287,7 @@ private function setMockResolverClass(
         if (isset($mockCustomModules)) {
             $mockMethods['getCustomModulePaths'] = $mockCustomModules;
         }
-        $mockMethods['printMagentoVersionInfo'] = null;
+//        $mockMethods['printMagentoVersionInfo'] = null;
 
         $mockResolver = AspectMock::double(
             ModuleResolver::class,
@@ -313,6 +352,11 @@ private function mockForceGenerate($forceGenerate)
      */
     protected function tearDown()
     {
+        // re set env
+        if (!isset($_ENV['MAGENTO_ADMIN_USERNAME'])) {
+            $_ENV['MAGENTO_ADMIN_USERNAME'] = "admin";
+        }
+
         AspectMock::clean();
     }
 }