Skip to content

Commit 20a0cef

Browse files
committed
Code Review changes
1 parent dae9a3b commit 20a0cef

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

src/Magento/FunctionalTestingFramework/Util/TestGenerator.php

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1778,8 +1778,6 @@ private function addDollarSign($input)
17781778
return sprintf("$%s", ltrim($this->stripQuotes($input), '$'));
17791779
}
17801780

1781-
// @codingStandardsIgnoreStart
1782-
17831781
/**
17841782
* Wrap parameters into a function call.
17851783
*
@@ -1843,9 +1841,9 @@ private function wrapFunctionCallWithReturnValue($returnVariable, $actor, $actio
18431841
return $output;
18441842
}
18451843

1846-
// @codingStandardsIgnoreEnd
1847-
18481844
/**
1845+
* Closure returned is used as a callable for array_filter to remove null values from array
1846+
*
18491847
* @return callable
18501848
*/
18511849
private function filterNullCallback()
@@ -1857,6 +1855,7 @@ private function filterNullCallback()
18571855

18581856
/**
18591857
* Resolves {{_ENV.variable}} into getenv("variable") for test-runtime ENV referencing.
1858+
*
18601859
* @param array $args
18611860
* @param string $regex
18621861
* @param string $func
@@ -1926,6 +1925,8 @@ private function validateParameterArray($paramArray)
19261925
}
19271926

19281927
/**
1928+
* Verifies whether we have correctly wrapped array syntax
1929+
*
19291930
* @param string $paramArray
19301931
* @return boolean
19311932
*/
@@ -1972,6 +1973,8 @@ private function resolveValueByType($value = null, $type = null)
19721973
}
19731974

19741975
/**
1976+
* Determines correct scope based on parameter
1977+
*
19751978
* @param string $generationScope
19761979
* @return string
19771980
*/
@@ -2103,6 +2106,8 @@ private function printRuleErrorToConsole($key, $tagName, $attributes)
21032106
}
21042107

21052108
/**
2109+
* Wraps parameters array with opening and closing symbol.
2110+
*
21062111
* @param string $value
21072112
* @return string
21082113
*/
@@ -2112,6 +2117,8 @@ private function wrapParameterArray(string $value): string
21122117
}
21132118

21142119
/**
2120+
* Determines whether string provided contains decimal point characteristic for current locale
2121+
*
21152122
* @param string $outStr
21162123
* @return boolean
21172124
*/

0 commit comments

Comments
 (0)