MQE-904: Deliver changes from Magento Contribution Day

Author: okolesnyk

.env.example

@@ -19,7 +19,7 @@ MAGENTO_ADMIN_PASSWORD=123123q
 #SELENIUM_PROTOCOL=http
 #SELENIUM_PATH=/wd/hub
 
-#*** Browser for running tests, default chrome. Uncomment and change if you want to run tests on another browser (ex. firefox).
+#*** Browser for running tests, default chrome. Please change if you want to run tests on another browser (ex. firefox).
 BROWSER=chrome
 
 #*** Uncomment and set host & port if your dev environment needs different value other than MAGENTO_BASE_URL for Rest API Requests ***#

RoboFile.php

@@ -43,6 +43,7 @@ function buildProject()
      *
      * @param array $opts
      * @return void
+     * @throws Exception
      */
     function generateTests($opts = ['config' => null, 'force' => true, 'nodes' => null, 'debug' => false])
     {
@@ -60,7 +61,7 @@ function generateTests($opts = ['config' => null, 'force' => true, 'nodes' => nu
         }
 
         \Magento\FunctionalTestingFramework\Util\TestGenerator::getInstance()
-            ->createAllTestFiles($opts['config'], $opts['nodes'], $opts['debug'], $this->getOutput());
+            ->createAllTestFiles($opts['config'], $opts['nodes'], $opts['debug']);
         $this->say("Generate Tests Command Run");
     }
 

src/Magento/FunctionalTestingFramework/Util/TestGenerator.php

@@ -20,17 +20,13 @@
 use Magento\FunctionalTestingFramework\Test\Util\ActionObjectExtractor;
 use Magento\FunctionalTestingFramework\Test\Util\TestObjectExtractor;
 use Magento\FunctionalTestingFramework\Util\Filesystem\DirSetupUtil;
-use Robo\Common\IO;
-use Symfony\Component\Console\Output\OutputInterface;
 
 /**
  * Class TestGenerator
  * @SuppressWarnings(PHPMD.ExcessiveClassComplexity)
  */
 class TestGenerator
 {
-    use IO;
-
     const REQUIRED_ENTITY_REFERENCE = 'createDataKey';
     const GENERATED_DIR = '_generated';
     const DEFAULT_DIR = 'default';
@@ -56,6 +52,13 @@ class TestGenerator
      */
     private $tests;
 
+    /**
+     * Symfony output interface.
+     *
+     * @var Output
+     */
+    private $output;
+
     /**
      * TestGenerator constructor.
      *
@@ -73,6 +76,7 @@ private function __construct($exportDir, $tests)
             . DIRECTORY_SEPARATOR
             . $exportDir;
         $this->tests = $tests;
+        $this->output = new \Symfony\Component\Console\Output\ConsoleOutput();
     }
 
     /**
@@ -140,17 +144,13 @@ private function createCestFile($testPhp, $filename)
      * @param string $runConfig
      * @param int $nodes
      * @param bool $debug
-     * @param OutputInterface|null $output
      * @return void
      * @throws TestReferenceException
      * @throws \Exception
      */
-    public function createAllTestFiles($runConfig = null, $nodes = null, $debug = false, $output = null)
+    public function createAllTestFiles($runConfig = null, $nodes = null, $debug = false)
     {
         DirSetupUtil::createGroupDir($this->exportDirectory);
-        if ($output !== null) {
-            $this->setOutput($output);
-        }
 
         // create our manifest file here
         $testManifest = TestManifestFactory::makeManifest(
@@ -205,9 +205,8 @@ private function assembleTestPhp($testObject)
      *
      * @param BaseTestManifest $testManifest
      * @param int $nodes
+     * @param bool $debug
      * @return array
-     * @throws TestReferenceException
-     * @throws \Exception
      */
     private function assembleAllTestPhp($testManifest, $nodes, $debug = false)
     {
@@ -225,7 +224,7 @@ private function assembleAllTestPhp($testManifest, $nodes, $debug = false)
             $debugInformation = $test->getDebugInformation();
 
             $this->debug($debugInformation, $debug);
-            $this->debug('Finish creating test ' . $test->getCodeceptionName(), $debug);
+            $this->debug('Finish creating test ' . $test->getCodeceptionName() . PHP_EOL, $debug);
         }
 
         $testManifest->generate($nodes);
@@ -245,7 +244,7 @@ private function debug($messages, $debug = false)
         if ($debug && $messages) {
             $messages = (array) $messages;
             foreach ($messages as $message) {
-                $this->say($message);
+                $this->output->writeln($message);
             }
         }
     }