Skip to content

Commit 106aaba

Browse files
authored
Merge pull request #173 from magento/TurnOffReadinessLogging
MQE-1147: Turn Off Readiness Logging
2 parents b8ebe86 + d5348a0 commit 106aaba

File tree

2 files changed

+13
-5
lines changed

2 files changed

+13
-5
lines changed

src/Magento/FunctionalTestingFramework/Extension/PageReadinessExtension.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,6 +251,7 @@ private function shouldSkipCheck($step)
251251
* @param string $message
252252
* @param array $context
253253
* @return void
254+
* @SuppressWarnings(PHPMD)
254255
*/
255256
private function logDebug($message, $context = [])
256257
{
@@ -264,7 +265,8 @@ private function logDebug($message, $context = [])
264265
$logContext[$metric->getName() . '.failCount'] = $metric->getFailureCount();
265266
}
266267
$context = array_merge($logContext, $context);
267-
$this->logger->info($message, $context);
268+
//TODO REMOVE THIS LINE, UNCOMMENT LOGGER
269+
//$this->logger->info($message, $context);
268270
}
269271
}
270272
}

src/Magento/FunctionalTestingFramework/Extension/ReadinessMetrics/AbstractMetricCheck.php

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ private function getCurrentValue($refresh = false)
248248
*/
249249
public function getStoredValue()
250250
{
251-
return $this->storedValue;
251+
return $this->storedValue ?? null;
252252
}
253253

254254
/**
@@ -306,11 +306,13 @@ public function resetTracker()
306306
* @param string $message
307307
* @param array $context
308308
* @return void
309+
* @SuppressWarnings(PHPMD)
309310
*/
310311
protected function errorLog($message, $context = [])
311312
{
312313
$context = array_merge($this->getLogContext(), $context);
313-
$this->logger->error($message, $context);
314+
//TODO REMOVE THIS LINE, UNCOMMENT LOGGER
315+
//$this->logger->error($message, $context);
314316
}
315317

316318
/**
@@ -319,11 +321,13 @@ protected function errorLog($message, $context = [])
319321
* @param string $message
320322
* @param array $context
321323
* @return void
324+
* @SuppressWarnings(PHPMD)
322325
*/
323326
protected function infoLog($message, $context = [])
324327
{
325328
$context = array_merge($this->getLogContext(), $context);
326-
$this->logger->info($message, $context);
329+
//TODO REMOVE THIS LINE, UNCOMMENT LOGGER
330+
//$this->logger->info($message, $context);
327331
}
328332

329333
/**
@@ -332,12 +336,14 @@ protected function infoLog($message, $context = [])
332336
* @param string $message
333337
* @param array $context
334338
* @return void
339+
* @SuppressWarnings(PHPMD)
335340
*/
336341
protected function debugLog($message, $context = [])
337342
{
338343
if ($this->verbose) {
339344
$context = array_merge($this->getLogContext(), $context);
340-
$this->logger->debug($message, $context);
345+
//TODO REMOVE THIS LINE, UNCOMMENT LOGGER
346+
//$this->logger->debug($message, $context);
341347
}
342348
}
343349

0 commit comments

Comments
 (0)