From 73e4e1bc8f938b11f96795f1e1a438b160359f20 Mon Sep 17 00:00:00 2001
From: Matthias Zeis <admin@matthias-zeis.com>
Date: Sat, 2 Mar 2019 17:21:00 +0100
Subject: [PATCH] Move LineLength from ruleset to sniff (fixes #36)

---
 Magento/Sniffs/Files/LineLengthSniff.php   | 10 +++++++
 Magento/Tests/Files/LineLengthUnitTest.inc | 16 +++++++++++
 Magento/Tests/Files/LineLengthUnitTest.php | 32 ++++++++++++++++++++++
 Magento/ruleset.xml                        |  4 ---
 4 files changed, 58 insertions(+), 4 deletions(-)
 create mode 100644 Magento/Tests/Files/LineLengthUnitTest.inc
 create mode 100644 Magento/Tests/Files/LineLengthUnitTest.php

diff --git a/Magento/Sniffs/Files/LineLengthSniff.php b/Magento/Sniffs/Files/LineLengthSniff.php
index 528baeed..13bbb21a 100644
--- a/Magento/Sniffs/Files/LineLengthSniff.php
+++ b/Magento/Sniffs/Files/LineLengthSniff.php
@@ -19,6 +19,16 @@ class LineLengthSniff extends FilesLineLengthSniff
      */
     protected $previousLineContent = '';
 
+    /**
+     * @inheritdoc
+     */
+    public $lineLimit = 120;
+
+    /**
+     * @inheritdoc
+     */
+    public $absoluteLineLimit = 120;
+
     /**
      * @inheritdoc
      */
diff --git a/Magento/Tests/Files/LineLengthUnitTest.inc b/Magento/Tests/Files/LineLengthUnitTest.inc
new file mode 100644
index 00000000..b4faf889
--- /dev/null
+++ b/Magento/Tests/Files/LineLengthUnitTest.inc
@@ -0,0 +1,16 @@
+<?php
+
+// allowed
+$shortString = 'This is a short line';
+
+// triggers an error
+$tooLongString = 'This is a pretty long line. The code sniffer will report an error if a single line exceeds the maximum character count. You have need to insert a line break to avoid this error.';
+
+// allowed
+$longStringBrokenUp = 'This is a pretty long line. The code sniffer would report an error if this was written as a ' .
+                      'single line. You have to insert a line break to avoid this error.';
+
+// allowed by Magento Standard (Generic ruleset would trigger warning / error)
+$test = '012344567890123445678901234456789012344567890123445678901234456789';
+$test1 = '01234456789012344567890123445678901234456789012344567890123445678901234456789';
+$test2 = '012344567890123445678901234456789012344567890123445678901234456789012344567890123445678901234456789';
diff --git a/Magento/Tests/Files/LineLengthUnitTest.php b/Magento/Tests/Files/LineLengthUnitTest.php
new file mode 100644
index 00000000..a3125b00
--- /dev/null
+++ b/Magento/Tests/Files/LineLengthUnitTest.php
@@ -0,0 +1,32 @@
+<?php
+/**
+ * Copyright © Magento. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+namespace Magento\Tests\Files;
+
+use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest;
+
+/**
+ * Class LineLengthUnitTest
+ */
+class LineLengthUnitTest extends AbstractSniffUnitTest
+{
+    /**
+     * @inheritdoc
+     */
+    public function getErrorList()
+    {
+        return [
+            7 => 1
+        ];
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getWarningList()
+    {
+        return [];
+    }
+}
diff --git a/Magento/ruleset.xml b/Magento/ruleset.xml
index 40336962..184db8d5 100644
--- a/Magento/ruleset.xml
+++ b/Magento/ruleset.xml
@@ -118,10 +118,6 @@
         <type>warning</type>
     </rule>
     <rule ref="Magento.Files.LineLength">
-        <properties>
-            <property name="lineLimit" value="120"/>
-            <property name="absoluteLineLimit" value="120"/>
-        </properties>
         <severity>8</severity>
         <type>warning</type>
     </rule>