From 44ffa1be307ccd8ec7f10529d77baf4d72ce2e6d Mon Sep 17 00:00:00 2001
From: Lena Orobei <oorobei@magento.com>
Date: Thu, 28 Feb 2019 14:25:04 -0600
Subject: [PATCH] Removed ObjectManagerSniff since it detects a lot of core
 findings

---
 Magento/Sniffs/Classes/ObjectManagerSniff.php | 84 -------------------
 .../Tests/Classes/ObjectManagerUnitTest.inc   | 23 -----
 .../Tests/Classes/ObjectManagerUnitTest.php   | 40 ---------
 Magento/ruleset.xml                           |  4 -
 4 files changed, 151 deletions(-)
 delete mode 100644 Magento/Sniffs/Classes/ObjectManagerSniff.php
 delete mode 100644 Magento/Tests/Classes/ObjectManagerUnitTest.inc
 delete mode 100644 Magento/Tests/Classes/ObjectManagerUnitTest.php

diff --git a/Magento/Sniffs/Classes/ObjectManagerSniff.php b/Magento/Sniffs/Classes/ObjectManagerSniff.php
deleted file mode 100644
index f68052e4..00000000
--- a/Magento/Sniffs/Classes/ObjectManagerSniff.php
+++ /dev/null
@@ -1,84 +0,0 @@
-<?php
-/**
- * Copyright © Magento. All rights reserved.
- * See COPYING.txt for license details.
- */
-namespace Magento\Sniffs\Classes;
-
-use PHP_CodeSniffer\Sniffs\Sniff;
-use PHP_CodeSniffer\Files\File;
-
-/**
- * Class ObjectManagerSniff detects direct ObjectManager usage.
- */
-class ObjectManagerSniff implements Sniff
-{
-    /**
-     * String representation of warning.
-     *
-     * @var string
-     */
-    // phpcs:ignore Magento.Files.LineLength.MaxExceeded
-    protected $warningMessage = 'The direct use of ObjectManager is discouraged. Inject necessary dependencies via constructor.';
-
-    /**
-     * Warning violation code.
-     *
-     * @var string
-     */
-    protected $warningCode = 'ObjectManagerFound';
-
-    /**
-     * Possible names of ObjectManager variable or methods from where it can be called.
-     *
-     * @var array
-     */
-    protected $objectManagerNames = [
-        'om',
-        '_om',
-        'objectmanager',
-        '_objectmanager',
-        'getobjectmanager',
-    ];
-
-    /**
-     * ObjectManager methods we are looking for.
-     *
-     * @var array
-     */
-    protected $objectManagerMethods = [
-        'get',
-        'create',
-    ];
-
-    /**
-     * @inheritdoc
-     */
-    public function register()
-    {
-        return [T_OBJECT_OPERATOR, T_DOUBLE_COLON];
-    }
-
-    /**
-     * @inheritdoc
-     */
-    public function process(File $phpcsFile, $stackPtr)
-    {
-        $tokens = $phpcsFile->getTokens();
-        $methodPosition = $phpcsFile->findNext(T_STRING, $stackPtr + 1);
-        if ($methodPosition !== false &&
-            in_array($tokens[$methodPosition]['content'], $this->objectManagerMethods)
-        ) {
-            $objectManagerPosition = $phpcsFile->findPrevious([T_STRING, T_VARIABLE], $stackPtr - 1);
-            if ($objectManagerPosition !== false) {
-                $objectManagerName = strtolower($tokens[$objectManagerPosition]['content']);
-                if ($tokens[$objectManagerPosition]['code'] === T_VARIABLE) {
-                    $objectManagerName = substr($objectManagerName, 1);
-                }
-                if (in_array($objectManagerName, $this->objectManagerNames)) {
-                    $phpcsFile->addWarning($this->warningMessage, $stackPtr, $this->warningCode);
-                }
-            }
-        }
-    }
-}
diff --git a/Magento/Tests/Classes/ObjectManagerUnitTest.inc b/Magento/Tests/Classes/ObjectManagerUnitTest.inc
deleted file mode 100644
index 7492f011..00000000
--- a/Magento/Tests/Classes/ObjectManagerUnitTest.inc
+++ /dev/null
@@ -1,23 +0,0 @@
-<?php
-
-$this->_objectManager->get(\Magento\Sales\Model\Order::class);
-
-$this->_om->get(\Magento\Sales\Model\Order::class);
-
-$this->om->create(\Magento\Sales\Model\Order::class);
-
-$shipment = $this->objectManager->create(\Magento\Sales\Model\Order::class);
-
-$productModel = $this->_giftWrapHelper->getObjectManager()
-    ->create(\Magento\Sales\Model\Order::class);
-
-$order = $block->getObjectManager()->create(\Magento\Sales\Model\Order::class);
-
-$order = $block->getObjectManager()->get(\Magento\Sales\Model\Order::class);
-
-$om = $block->get(\Magento\Sales\Model\Order::class);
-
-$om = $objectManager::get(\Magento\Sales\Model\Order::class);
-
-$objectManager = \Magento\Framework\App\ObjectManager::getInstance();
-$product = $objectManager->create(\Magento\Sales\Model\Order::class);
diff --git a/Magento/Tests/Classes/ObjectManagerUnitTest.php b/Magento/Tests/Classes/ObjectManagerUnitTest.php
deleted file mode 100644
index 4190f8f6..00000000
--- a/Magento/Tests/Classes/ObjectManagerUnitTest.php
+++ /dev/null
@@ -1,40 +0,0 @@
-<?php
-/**
- * Copyright © Magento. All rights reserved.
- * See COPYING.txt for license details.
- */
-namespace Magento\Tests\Classes;
-
-use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest;
-
-/**
- * Class ObjectManagerUnitTest
- */
-class ObjectManagerUnitTest extends AbstractSniffUnitTest
-{
-    /**
-     * @inheritdoc
-     */
-    public function getErrorList()
-    {
-        return [];
-    }
-
-    /**
-     * @inheritdoc
-     */
-    public function getWarningList()
-    {
-        return [
-            3 => 1,
-            5 => 1,
-            7 => 1,
-            9 => 1,
-            12 => 1,
-            14 => 1,
-            16 => 1,
-            20 => 1,
-            23 => 1,
-        ];
-    }
-}
diff --git a/Magento/ruleset.xml b/Magento/ruleset.xml
index 91f4c72f..0e99b3f8 100644
--- a/Magento/ruleset.xml
+++ b/Magento/ruleset.xml
@@ -109,10 +109,6 @@
         <severity>8</severity>
         <type>warning</type>
     </rule>
-    <rule ref="Magento.Classes.ObjectManager">
-        <severity>8</severity>
-        <type>warning</type>
-    </rule>
     <rule ref="Magento.Exceptions.DirectThrow">
         <severity>8</severity>
         <type>warning</type>