#26: Add Sniff for Gettersnot change state

Author: Lars Roettig

Magento/Sniffs/Functions/GetterStateSniff.php

@@ -45,7 +45,7 @@ public function process(File $phpcsFile, $stackPtr)
     {
         $methodName = $phpcsFile->getDeclarationName($stackPtr);
 
-        if ($methodName === null || strpos($methodName, 'get') === false) {
+        if ($methodName === null || strpos($methodName, 'get') !== 0) {
             // Ignore closures and no getters
             return;
         }

Magento/Tests/Functions/GetterStateUnitTest.inc

@@ -40,6 +40,12 @@ class Foo extends Bar
         return $this->property;
     }
 
+    public function TestigetFoo()
+    {
+        $this->property = 1223;
+        return $this->property;
+    }
+
     /**
      * @return int
      */