From 75cde7d822da2e8d6abbb5a630599996b8b70325 Mon Sep 17 00:00:00 2001 From: Joseph Maxwell Date: Tue, 3 Mar 2020 06:36:37 -0600 Subject: [PATCH 1/2] Small grammar updates --- src/guides/v2.3/howdoi/checkout/checkout_payment.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/guides/v2.3/howdoi/checkout/checkout_payment.md b/src/guides/v2.3/howdoi/checkout/checkout_payment.md index 5736cbf460f..c3a178909ec 100644 --- a/src/guides/v2.3/howdoi/checkout/checkout_payment.md +++ b/src/guides/v2.3/howdoi/checkout/checkout_payment.md @@ -159,7 +159,7 @@ This configuration is stored in the `window.checkoutConfig` variable that is def In order to get access to the system configuration, your payment method or a group of payment methods has to implement the [`\Magento\Checkout\Model\ConfigProviderInterface`]({{ site.mage2bloburl }}/{{ page.guide_version }}/app/code/Magento/Checkout/Model/ConfigProviderInterface.php) interface, and the class implementing it must be injected to the composite config provider via DI [frontend](https://glossary.magento.com/frontend) configuration. The following code samples illustrate this. -A sample `.php` class implementing `\Magento\Checkout\Model\ConfigProviderInterface`: +This is a sample `.php` file implementing `\Magento\Checkout\Model\ConfigProviderInterface`: ```php?start_inline=1 class MyCustomPaymentConfigProvider implements \Magento\Checkout\Model\ConfigProviderInterface @@ -175,7 +175,7 @@ class MyCustomPaymentConfigProvider implements \Magento\Checkout\Model\ConfigPro } ``` -A sample DI configuration file of a custom module `/etc/frontend/di.xml`: +Here is the associated sample DI configuration file of a custom module `/etc/frontend/di.xml`: ```xml ... From ae527622a5d5ced84b0b6db309586369ce65cb21 Mon Sep 17 00:00:00 2001 From: Joseph Maxwell Date: Tue, 3 Mar 2020 07:18:51 -0600 Subject: [PATCH 2/2] Update requirejs.md --- src/guides/v2.3/javascript-dev-guide/javascript/requirejs.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/guides/v2.3/javascript-dev-guide/javascript/requirejs.md b/src/guides/v2.3/javascript-dev-guide/javascript/requirejs.md index 7fb1e05aa45..98b79672db2 100644 --- a/src/guides/v2.3/javascript-dev-guide/javascript/requirejs.md +++ b/src/guides/v2.3/javascript-dev-guide/javascript/requirejs.md @@ -52,7 +52,7 @@ You can also use the `map` configuration to override a JS module with a custom J ### paths {#requirejs-config-paths} -The `paths` configuration, similar to `map`, is used for aliasing not just any real AMD module that calls `define()`, but also any JS file (event from a URL), HTML templates, etc. Magento uses this to alias URLs and third party libraries. +The `paths` configuration, similar to `map`, is used for aliasing not just any real AMD module that calls `define()`, but also any JS file (even from a URL), HTML templates, etc. Magento uses this to alias URLs and third party libraries. ```javascript paths: { @@ -95,7 +95,7 @@ shim: { ### mixins {#requirejs-config-mixin} -The `mixins` configuration is used to overwrite component methods of an AMD module which returns either a UI component,a jQuery widget, or a JS object. Unlike the above configuration properties, the `mixins` property is under the `config` property, apart from the parent object called **config**. +The `mixins` configuration is used to overwrite component methods of an AMD module which returns either a UI component, a jQuery widget, or a JS object. Unlike the above configuration properties, the `mixins` property is under the `config` property, apart from the parent object called **config**. In this snippet, `Vendor_Module/js/module-mixin` will overwrite the existing component methods in `Vendor_Module/js/module` with the specified component methods. It is a convention to name the mixin by appending a `-mixin` to the original `path/to/js`, although not required.