Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Commit 013a2c5

Browse files
authored
Merge pull request #6808 from magento/small-changes
Small changes
2 parents 64d16c6 + a19fc44 commit 013a2c5

File tree

18 files changed

+32
-31
lines changed

18 files changed

+32
-31
lines changed

src/cloud/docker/docker-containers.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ For example, the following command starts the Docker configuration generator in
4949
./vendor/bin/ece-docker build:compose --mode="developer" --php 7.2
5050
```
5151

52-
See [See Docker services containters] for details.
52+
See [Docker service containers][] for details.
5353

5454
## Request Flow
5555

@@ -137,7 +137,7 @@ Now you can see all requests that are passing through the TLS container and chec
137137
[db]: {{site.baseurl}}/cloud/docker/docker-containers-service.html#database-container
138138
[elasticsearch]: {{site.baseurl}}/cloud/docker/docker-containers-service.html#elasticsearch-container
139139
[Docker CLI containers]: {{site.baseurl}}/cloud/docker/docker-containers-cli.html
140-
[Docker service containers]: {{site.baseurl}}/cloud/docker-containers-service.html
140+
[Docker service containers]: {{site.baseurl}}/cloud/docker/docker-containers-service.html
141141
[Web containers]: {{site.baseurl}}/cloud/docker/docker-php.html
142142
[Developer Mode]: {{site.baseurl}}/cloud/docker/docker-mode-developer.html
143143
[File Synchronization]: {{site.baseurl}}/cloud/docker/docker-syncing-data.html

src/cloud/docker/docker-mode-production.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ Production mode is the default configuration setting for launching the Docker en
1212
{%include cloud/note-docker-config-reference-link.md%}
1313

1414
{:.procedure}
15-
To launch the Docker environment in developer mode:
15+
To launch the Docker environment in production mode:
1616

1717
1. Download a Magento application template from the [Magento Cloud repository][cloud-repo]. Be careful to select the branch that corresponds with the Magento version.
1818

@@ -95,4 +95,4 @@ To launch the Docker environment in developer mode:
9595
[cloud-repo]: https://github.com/magento/magento-cloud
9696
[magento-creds]: {{site.baseurl}}/guides/v2.3/install-gde/prereq/connect-auth.html
9797
[services]: {{site.baseurl}}/cloud/docker/docker-containers.html#service-containers
98-
[configure Xdebug]: {{site.baseurl}}/cloud/docker/docker-development-debug.html#configure-xdebug
98+
[configure Xdebug]: {{site.baseurl}}/cloud/docker/docker-development-debug.html#configure-xdebug

src/cloud/release-notes/ece-release-notes.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ See [Upgrades and patches]({{ site.baseurl }}/cloud/project/project-upgrade-pare
5656

5757
- {:.new}Added the `ERROR_REPORT_DIR_NESTING_LEVEL` environment variable to simplify error report data management in the `<magento_root>/var/report/` directory. See the variable description in the [build variables]({{site.baseurl}}/cloud/env/variables-build.html#error_report_dir_nesting_level) topic.
5858

59-
- {:.fix}Removed the `SCD_EXCLUDE_THEMES`, `STATIC_CONTENT_THREADS`,`DO_DEPLOY_STATIC_CONTENT`, `SKIP_SCD`, and `STATIC_CONTENT_SYMLINK` environment variables. See [Backward incompatible changes]({{site.baseurl}}/cloud/release-notes/backward-incompatible-changes.html#environment-configuration-changes).<!--MAGECLOUD-4407, MAGECLOUD-3873-->
59+
- {:.fix}Removed the `SCD_EXCLUDE_THEMES`, `STATIC_CONTENT_THREADS`,`DO_DEPLOY_STATIC_CONTENT`, and `STATIC_CONTENT_SYMLINK` environment variables. See [Backward incompatible changes]({{site.baseurl}}/cloud/release-notes/backward-incompatible-changes.html#environment-configuration-changes).<!--MAGECLOUD-4407, MAGECLOUD-3873-->
6060

6161
- {:.fix}Fixed an issue in the Elastic Suite configuration process so that the default configuration is overwritten as expected when you configure the `ELASTICSUITE_CONFIGURATION` deploy variable without the `_merge` option.<!--MAGECLOUD-4388-->
6262

0 Bytes
Loading

src/guides/v2.3/frontend-dev-guide/tools/using_grunt.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,11 @@ Where the following notation is used:
7777
- `<language>`: specified in the `code_subtag` format, for example `en_US`. Only one locale can be specified here. To debug the theme with another locale, create one more theme declaration, having specified another value for `language`.
7878
- `<path_to_file>`: path to the root source file, relative to the `app/design/frontend/<Vendor>/<theme>/web` directory. You need to specify all [root source files of the theme]({{ page.baseurl }}/frontend-dev-guide/css-topics/css-preprocess.html#css_preprocess_terms). If your theme [inherits] from a certain theme, and does not contain its own root source files, specify the root source files of the parent theme.
7979
80+
Once these are set correctly, run grunt to watch your changes.
81+
82+
- Run `grunt exec:<theme>` from the root directory to republish the symlinks.
83+
- Run `grunt watch:<theme>` so that grunt will watch for file changes.
84+
8085
## Using custom Grunt configuration files
8186
8287
There are several ways to declare a custom configuration file.

src/guides/v2.3/graphql/develop/resolvers.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -341,9 +341,9 @@ type Customer @doc(description: "Customer defines the customer name and address
341341
default_shipping: String @doc(description: "The ID assigned to the shipping address")
342342
date_of_birth: String @doc(description: "The customer's date of birth")
343343
taxvat: String @doc(description: "The customer's Tax/VAT number (for corporate customers)")
344-
id: Int @doc(description: "The ID assigned to the customer")
345344
is_subscribed: Boolean @doc(description: "Indicates whether the customer is subscribed to the company's newsletter") @resolver(class: "\\Magento\\CustomerGraphQl\\Model\\Resolver\\IsSubscribed")
346345
addresses: [CustomerAddress] @doc(description: "An array containing the customer's shipping and billing addresses")
346+
gender: Int @doc(description: "The customer's gender (Male - 1, Female - 2)")
347347
}
348348
```
349349

@@ -361,7 +361,6 @@ mutation {
361361
}
362362
) {
363363
customer {
364-
id
365364
firstname
366365
lastname
367366
email
@@ -378,7 +377,6 @@ A sample response:
378377
"data": {
379378
"createCustomer": {
380379
"customer": {
381-
"id": 5,
382380
"firstname": "John",
383381
"lastname": "Doe",
384382
"email": "j.doe@example.com",

src/guides/v2.3/graphql/mutations/apply-coupon.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ mutation {
3232
}
3333
quantity
3434
}
35-
applied_coupon {
35+
applied_coupons {
3636
code
3737
}
3838
prices {
@@ -73,7 +73,7 @@ mutation {
7373
"quantity": 1
7474
}
7575
],
76-
"applied_coupon": {
76+
"applied_coupons": {
7777
"code": "H20"
7878
},
7979
"prices": {

src/guides/v2.3/graphql/mutations/create-customer-address.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ mutation {
3737
id
3838
region {
3939
region
40-
region_id
4140
region_code
4241
}
4342
country_code

src/guides/v2.3/graphql/mutations/place-order.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,8 @@ Attribute | Data Type | Description
7373

7474
Attribute | Data Type | Description
7575
--- | --- | ---
76-
`order_id` String | The unique ID that identifies the order
77-
`order_number` String | The unique ID that identifies the order
76+
`order_id` | String! | Deprecated. Use `order_number` instead. The unique ID that identifies the order
77+
`order_number` | String | The unique ID that identifies the order
7878

7979
## Errors
8080

src/guides/v2.3/graphql/mutations/remove-coupon.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ mutation {
3030
}
3131
quantity
3232
}
33-
applied_coupon {
33+
applied_coupons {
3434
code
3535
}
3636
prices {
@@ -65,7 +65,7 @@ mutation {
6565
"quantity": 1
6666
}
6767
],
68-
"applied_coupon": null,
68+
"applied_coupons": null,
6969
"prices": {
7070
"grand_total": {
7171
"value": 39,

src/guides/v2.3/graphql/queries/customer.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ The following call returns information about the logged-in customer. Provide the
3737
region {
3838
region_code
3939
region
40-
region_id
4140
}
4241
postcode
4342
country_code
@@ -68,8 +67,7 @@ The following call returns information about the logged-in customer. Provide the
6867
"city": "Anytown",
6968
"region": {
7069
"region_code": "MI",
71-
"region": "Michigan",
72-
"region_id": 33
70+
"region": "Michigan"
7371
}
7472
"postcode": "78758",
7573
"country_code": "US",

src/guides/v2.3/graphql/tutorials/checkout/checkout-coupon.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ mutation {
3434
}
3535
) {
3636
cart {
37-
applied_coupon {
37+
applied_coupons {
3838
code
3939
}
4040
}
@@ -49,7 +49,7 @@ mutation {
4949
"data": {
5050
"applyCouponToCart": {
5151
"cart": {
52-
"applied_coupon": {
52+
"applied_coupons": {
5353
"code": "{ COUPON_CODE }"
5454
}
5555
}
@@ -69,7 +69,7 @@ For logged-in customers, send the customer's authorization token in the `Authori
6969
mutation {
7070
removeCouponFromCart(input: { cart_id: "{ CART_ID }" }) {
7171
cart {
72-
applied_coupon {
72+
applied_coupons {
7373
code
7474
}
7575
}
@@ -84,7 +84,7 @@ mutation {
8484
"data": {
8585
"removeCouponFromCart": {
8686
"cart": {
87-
"applied_coupon": {
87+
"applied_coupons": {
8888
"applied_coupon": null
8989
}
9090
}

src/guides/v2.3/howdoi/checkout/checkout_payment.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ This configuration is stored in the `window.checkoutConfig` variable that is def
159159

160160
In order to get access to the system configuration, your payment method or a group of payment methods has to implement the [`\Magento\Checkout\Model\ConfigProviderInterface`]({{ site.mage2bloburl }}/{{ page.guide_version }}/app/code/Magento/Checkout/Model/ConfigProviderInterface.php) interface, and the class implementing it must be injected to the composite config provider via DI [frontend](https://glossary.magento.com/frontend) configuration. The following code samples illustrate this.
161161

162-
A sample `.php` class implementing `\Magento\Checkout\Model\ConfigProviderInterface`:
162+
This is a sample `.php` file implementing `\Magento\Checkout\Model\ConfigProviderInterface`:
163163

164164
```php?start_inline=1
165165
class MyCustomPaymentConfigProvider implements \Magento\Checkout\Model\ConfigProviderInterface
@@ -175,7 +175,7 @@ class MyCustomPaymentConfigProvider implements \Magento\Checkout\Model\ConfigPro
175175
}
176176
```
177177

178-
A sample DI configuration file of a custom module `<your_module_dir>/etc/frontend/di.xml`:
178+
Here is the associated sample DI configuration file of a custom module `<your_module_dir>/etc/frontend/di.xml`:
179179

180180
```xml
181181
...

src/guides/v2.3/javascript-dev-guide/javascript/requirejs.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ All configuration is done in the `requirejs-config.js` file. It has a single roo
1717
var config = {
1818
'map': {...},
1919
'paths': {...},
20+
'deps':[...],
2021
'shim': {...},
2122
'config': {
2223
'mixins': {...},
@@ -52,7 +53,7 @@ You can also use the `map` configuration to override a JS module with a custom J
5253

5354
### paths {#requirejs-config-paths}
5455

55-
The `paths` configuration, similar to `map`, is used for aliasing not just any real AMD module that calls `define()`, but also any JS file (event from a URL), HTML templates, etc. Magento uses this to alias URLs and third party libraries.
56+
The `paths` configuration, similar to `map`, is used for aliasing not just any real AMD module that calls `define()`, but also any JS file (even from a URL), HTML templates, etc. Magento uses this to alias URLs and third party libraries.
5657

5758
```javascript
5859
paths: {
@@ -95,7 +96,7 @@ shim: {
9596

9697
### mixins {#requirejs-config-mixin}
9798

98-
The `mixins` configuration is used to overwrite component methods of an AMD module which returns either a UI component,a jQuery widget, or a JS object. Unlike the above configuration properties, the `mixins` property is under the `config` property, apart from the parent object called **config**.
99+
The `mixins` configuration is used to overwrite component methods of an AMD module which returns either a UI component, a jQuery widget, or a JS object. Unlike the above configuration properties, the `mixins` property is under the `config` property, apart from the parent object called **config**.
99100

100101
In this snippet, `Vendor_Module/js/module-mixin` will overwrite the existing component methods in `Vendor_Module/js/module` with the specified component methods. It is a convention to name the mixin by appending a `-mixin` to the original `path/to/js`, although not required.
101102

src/guides/v2.3/ui_comp_guide/concepts/ui_comp_modifier_concept.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ Declare your modifier in your module Di configuration `<Your_Module_dir>/etc/adm
9797
</virtualType>
9898
```
9999

100-
, where `YourNamespace\YourModule\DataProvider\Modifier\Pool` is a [virtual class]({{ page.baseurl }}/extension-dev-guide/depend-inj.html#dependency-types).
100+
where `YourNamespace\YourModule\DataProvider\Modifier\Pool` is a [virtual class]({{ page.baseurl }}/extension-dev-guide/depend-inj.html#dependency-types).
101101

102102
(If you want to use this sample in your `di.xml`, replace the sample values with the real names of your entities.)
103103

src/guides/v2.3/ui_comp_guide/concepts/ui_comp_template_literals.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ Perhaps the most useful aspect of template literals is the ability to access oth
4646

4747
UI Components can have a `<item name="config" xsi:type="array">...</item>` node in the primary XML declaration file ([see an example]({{ page.baseurl }}/ui_comp_guide/concepts/ui_comp_xmldeclaration_concept.html#example-of-a-basic-components-configuration-file)). In that file, a `component` element can be added with a path reference to the RequireJS file. That file is loaded into the registry when it runs on the frontend and other JavaScript files can then access it by the *name* of the UI Component instead of the path to the file itself. The name often will look something like this: `example_component.example_component`.
4848

49-
Names of other registered modules can be added to the [server side](https://glossary.magento.com/server-side) configuration (XML or PHP) that is output through JSON. Those names can then be easily accessed in the JavaScript on the frontend. In the following example, the other UI Component's name will be obtained with a template literal in the `imports` object. When this JavaScript file is loaded, it will process the template literal and look up the name in the registry. If found, it will load that class. Because there is a colon (`:`), it will go on to find the property that is accessed in the other JavaScript class.
49+
Names of other registered modules can be added to the [server side](https://glossary.magento.com/server-side) configuration ([XML](https://glossary.magento.com/xml) or [PHP](https://glossary.magento.com/php)) that is output through JSON. Those names can then be easily accessed in the JavaScript on the frontend. In the following example, the other UI Component's name will be obtained with a template literal in the `imports` object. When this JavaScript file is loaded, it will process the template literal and look up the name in the registry. If found, it will load that class. Because there is a colon (`:`), it will go on to find the property that is accessed in the other JavaScript class.
5050

5151
```javascript
5252
return Element.extend({

src/guides/v2.3/ui_comp_guide/concepts/ui_comp_uiclass_concept.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ initialize: function () {
4848
}
4949
```
5050

51-
* The `_super()` method calls the parent UI component method with the same name as the `_super()` method's caller; if that method does not exists in the parent UI component, then the method tries to find it higher in the inheritance chain.
51+
* The `_super()` method calls the parent UI component method with the same name as the `_super()` method's caller. If that method does not exists in the parent UI component, then the method tries to find it higher in the inheritance chain.
5252

5353
As an example:
5454

src/guides/v2.3/ui_comp_guide/concepts/ui_comp_xmldeclaration_concept.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ The instance configuration file name is the name of instance (`%instance_name%`)
3030
Following are the rules for the instance configuration files:
3131

3232
* The top node must have the name of one of the basic UI components. <!-- need to mention or link what components -->
33-
* The top node must contain a link to the XSD schema.
33+
* The top node must contain a link to the [XSD](https://glossary.magento.com/xsd) schema.
3434

3535
In the top node, there can be an `<argument/>` node. The `<argument/>` node contains the configuration for that basic UI component. The `<argument/>` node's `name` attribute value must be `data`. The child nodes of the `<argument>` node will be the argument properties that will be passed in to the component.
3636

@@ -107,7 +107,7 @@ In the above example, within the top-level `<form>` node the `<fieldset>` node i
107107

108108
The `name` attribute value must be a unique among the other components on the same hierarchical level of the same parent node. Look at the `<argument>` node which `name` attribute has `data` value. The child nodes of this node are the arguments that will be passed in to the component.
109109

110-
All other child nodes are declared as items. `<item name="config"> ...</item>` contains the children nodes that describe the configuration of the current UI component. Please note that although configuration for all components is different, there are base properties that are mostly the same for different components. For example, we can use `<item name="component">...</item>` to define which JS file will be used as the Model for the Fieldset UI component in the above example. Reference to this JS file can be either be the full path to this file or the alias which is defined in [`require.js` configuration]({{ page.baseurl }}/javascript-dev-guide/javascript/js-resources.html).
110+
All other child nodes are declared as items. `<item name="config"> ...</item>` contains the children nodes that describe the configuration of the current UI component. Please note that although configuration for all components is different, there are base properties that are mostly the same for different components. For example, we can use `<item name="component">...</item>` to define which JS file will be used as the Model for the Fieldset UI component in the above example. Reference to this JS file can be either be the full path to this file or the alias which is defined in [`require.js`]({{ page.baseurl }}/javascript-dev-guide/javascript/js-resources.html) configuration.
111111

112112
In our example, the `<item name="component">...</item>` node within `<fieldset>` is omitted, because this property of the Fieldset UI component is already defined in `definition.xml`.
113113

0 commit comments

Comments
 (0)