Merge pull request #23 from maartenpaauw/feature/add-override-attributes

Add override attributes

Author: maartenpaauw

composer.json

@@ -19,7 +19,8 @@
         "php": "^8.1",
         "illuminate/console": "^10.0|^11.0",
         "illuminate/support": "^10.0|^11.0",
-        "spatie/laravel-package-tools": "^1.16.2"
+        "spatie/laravel-package-tools": "^1.16.2",
+        "symfony/polyfill-php83": "^1.30"
     },
     "require-dev": {
         "illuminate/testing": "^10.0|^11.0",

src/AndSpecification.php

@@ -4,6 +4,8 @@
 
 namespace Maartenpaauw\Specifications;
 
+use Override;
+
 /**
  * @template TCandidate
  *
@@ -18,6 +20,7 @@ public function __construct(
         private readonly array $specifications,
     ) {}
 
+    #[Override]
     public function isSatisfiedBy(mixed $candidate): bool
     {
         foreach ($this->specifications as $specification) {

src/Commands/MakeSpecificationCommand.php

@@ -5,6 +5,7 @@
 namespace Maartenpaauw\Specifications\Commands;
 
 use Illuminate\Console\GeneratorCommand;
+use Override;
 use Symfony\Component\Console\Attribute\AsCommand;
 use Symfony\Component\Console\Input\InputOption;
 
@@ -19,6 +20,7 @@ final class MakeSpecificationCommand extends GeneratorCommand
      */
     protected $type = 'Specification';
 
+    #[Override]
     protected function getStub(): string
     {
         if ($this->option('composite')) {
@@ -35,6 +37,7 @@ protected function getStub(): string
     /**
      * @inheritDoc
      */
+    #[Override]
     protected function getDefaultNamespace(mixed $rootNamespace): string
     {
         return sprintf('%s\Specifications', $rootNamespace);
@@ -43,6 +46,7 @@ protected function getDefaultNamespace(mixed $rootNamespace): string
     /**
      * @inheritDoc
      */
+    #[Override]
     protected function buildClass(mixed $name): string
     {
         $replacements = [
@@ -59,6 +63,7 @@ protected function buildClass(mixed $name): string
     /**
      * @return array<int, InputOption>
      */
+    #[Override]
     protected function getOptions(): array
     {
         return [

src/NotSpecification.php

@@ -4,6 +4,8 @@
 
 namespace Maartenpaauw\Specifications;
 
+use Override;
+
 /**
  * @template TCandidate
  *
@@ -18,6 +20,7 @@ public function __construct(
         private readonly Specification $specification,
     ) {}
 
+    #[Override]
     public function isSatisfiedBy(mixed $candidate): bool
     {
         return ! $this->specification->isSatisfiedBy($candidate);

src/OrSpecification.php

@@ -4,6 +4,8 @@
 
 namespace Maartenpaauw\Specifications;
 
+use Override;
+
 /**
  * @template TCandidate
  *
@@ -18,6 +20,7 @@ public function __construct(
         private readonly array $specifications,
     ) {}
 
+    #[Override]
     public function isSatisfiedBy(mixed $candidate): bool
     {
         foreach ($this->specifications as $specification) {

src/SpecificationsServiceProvider.php

@@ -7,11 +7,13 @@
 use Illuminate\Support\Collection;
 use Maartenpaauw\Specifications\Commands\MakeSpecificationCommand;
 use Maartenpaauw\Specifications\Laravel\CollectionMatchingMacro;
+use Override;
 use Spatie\LaravelPackageTools\Package;
 use Spatie\LaravelPackageTools\PackageServiceProvider;
 
 final class SpecificationsServiceProvider extends PackageServiceProvider
 {
+    #[Override]
     public function configurePackage(Package $package): void
     {
         $package
@@ -20,6 +22,7 @@ public function configurePackage(Package $package): void
             ->hasCommand(MakeSpecificationCommand::class);
     }
 
+    #[Override]
     public function packageRegistered(): void
     {
         /** @var string $method */

src/VerboseSpecification.php

@@ -4,6 +4,8 @@
 
 namespace Maartenpaauw\Specifications;
 
+use Override;
+
 /**
  * @template TCandidate
  *
@@ -40,6 +42,7 @@ public function message(): string
      *
      * @throws DissatisfiedSpecification
      */
+    #[Override]
     public function isSatisfiedBy(mixed $candidate): bool
     {
         if ($this->origin->isSatisfiedBy($candidate)) {

src/XorSpecification.php

@@ -4,6 +4,8 @@
 
 namespace Maartenpaauw\Specifications;
 
+use Override;
+
 /**
  * @template TCandidate
  *
@@ -18,6 +20,7 @@ public function __construct(
         private readonly array $specifications,
     ) {}
 
+    #[Override]
     public function isSatisfiedBy(mixed $candidate): bool
     {
         $satisfiedSpecifications = array_filter(

tests/Commands/MakeSpecificationCommandTest.php

@@ -96,6 +96,6 @@ public function test_it_should_be_possible_to_create_a_composite_specification_w
 
     protected function assertSpecificationMatchesSnapshot(string $name): void
     {
-        $this->assertMatchesFileSnapshot(app_path(sprintf('Specifications/%s.php', $name)));
+        $this->assertMatchesFileSnapshot(app_path(\sprintf('Specifications/%s.php', $name)));
     }
 }

workbench/app/LengthSpecification.php

@@ -5,6 +5,7 @@
 namespace Workbench\App;
 
 use Maartenpaauw\Specifications\CompositeSpecification;
+use Override;
 
 /**
  * @extends CompositeSpecification<string>
@@ -18,6 +19,7 @@ public function __construct(
     /**
      * @inheritDoc
      */
+    #[Override]
     public function isSatisfiedBy(mixed $candidate): bool
     {
         return mb_strlen($candidate) === $this->length;

workbench/app/NegativeSpecification.php

@@ -5,6 +5,7 @@
 namespace Workbench\App;
 
 use Maartenpaauw\Specifications\CompositeSpecification;
+use Override;
 
 /**
  * @extends CompositeSpecification<mixed>
@@ -14,6 +15,7 @@ final class NegativeSpecification extends CompositeSpecification
     /**
      * @inheritDoc
      */
+    #[Override]
     public function isSatisfiedBy(mixed $candidate): bool
     {
         return false;

workbench/app/PositiveSpecification.php

@@ -5,6 +5,7 @@
 namespace Workbench\App;
 
 use Maartenpaauw\Specifications\CompositeSpecification;
+use Override;
 
 /**
  * @extends CompositeSpecification<mixed>
@@ -14,6 +15,7 @@ final class PositiveSpecification extends CompositeSpecification
     /**
      * @inheritDoc
      */
+    #[Override]
     public function isSatisfiedBy(mixed $candidate): bool
     {
         return true;

workbench/app/UppercaseSpecification.php

@@ -5,6 +5,7 @@
 namespace Workbench\App;
 
 use Maartenpaauw\Specifications\CompositeSpecification;
+use Override;
 
 /**
  * @extends CompositeSpecification<string>
@@ -14,6 +15,7 @@ final class UppercaseSpecification extends CompositeSpecification
     /**
      * @inheritDoc
      */
+    #[Override]
     public function isSatisfiedBy(mixed $candidate): bool
     {
         return mb_strtoupper($candidate) === $candidate;