From 7c1651cd26441e0e444660630a70966eff1a65a7 Mon Sep 17 00:00:00 2001 From: freddysundowner Date: Thu, 9 May 2024 10:22:58 +0300 Subject: [PATCH 1/2] fixed auto height on the stream video comp --- client/packages/lowcoder/src/comps/comps/remoteComp/loaders.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/packages/lowcoder/src/comps/comps/remoteComp/loaders.tsx b/client/packages/lowcoder/src/comps/comps/remoteComp/loaders.tsx index 4390a7bb9..2be99878c 100644 --- a/client/packages/lowcoder/src/comps/comps/remoteComp/loaders.tsx +++ b/client/packages/lowcoder/src/comps/comps/remoteComp/loaders.tsx @@ -13,7 +13,7 @@ async function npmLoader( // Falk: removed "packageVersion = "latest" as default value fir packageVersion - to ensure no automatic version jumping. const localPackageVersion = remoteInfo.packageVersion || "latest"; - + const { packageName, packageVersion, compName } = remoteInfo; const entry = `${NPM_PLUGIN_ASSETS_BASE_URL}/${packageName}@${localPackageVersion}/index.js`; // const entry = `../../../../../public/package/index.js`; From 1f4ce933b98219dd3542161928d92947e36c3f8e Mon Sep 17 00:00:00 2001 From: freddysundowner Date: Thu, 9 May 2024 10:23:29 +0300 Subject: [PATCH 2/2] fixed auto height on the stream video comp --- .../src/comps/agoraMeetingComp/videoMeetingStreamComp.tsx | 6 +++--- .../src/comps/agoraMeetingComp/videoSharingStreamComp.tsx | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/client/packages/lowcoder-comps/src/comps/agoraMeetingComp/videoMeetingStreamComp.tsx b/client/packages/lowcoder-comps/src/comps/agoraMeetingComp/videoMeetingStreamComp.tsx index 3831f203b..7c5569804 100644 --- a/client/packages/lowcoder-comps/src/comps/agoraMeetingComp/videoMeetingStreamComp.tsx +++ b/client/packages/lowcoder-comps/src/comps/agoraMeetingComp/videoMeetingStreamComp.tsx @@ -225,7 +225,7 @@ let VideoCompBuilder = (function () { {children.profileBorderRadius.propertyView({ label: "Profile Image Border Radius", })} - {children.videoAspectRatio.propertyView({ + {children.videoAspectRatio.propertyView({ label: "Video Aspect Ratio", })} {children.style.getPropertyView()} @@ -239,7 +239,7 @@ let VideoCompBuilder = (function () { VideoCompBuilder = class extends VideoCompBuilder { autoHeight(): boolean { - return false; + return this.children.autoHeight.getView(); } }; @@ -247,5 +247,5 @@ export const VideoMeetingStreamComp = withExposingConfigs(VideoCompBuilder, [ new NameConfig("loading", trans("meeting.loadingDesc")), new NameConfig("profileImageUrl", trans("meeting.profileImageUrl")), - ...CommonNameConfig, + ...CommonNameConfig, ]); diff --git a/client/packages/lowcoder-comps/src/comps/agoraMeetingComp/videoSharingStreamComp.tsx b/client/packages/lowcoder-comps/src/comps/agoraMeetingComp/videoSharingStreamComp.tsx index 902f34a7c..35b94ebdf 100644 --- a/client/packages/lowcoder-comps/src/comps/agoraMeetingComp/videoSharingStreamComp.tsx +++ b/client/packages/lowcoder-comps/src/comps/agoraMeetingComp/videoSharingStreamComp.tsx @@ -223,7 +223,7 @@ let SharingCompBuilder = (function () { SharingCompBuilder = class extends SharingCompBuilder { autoHeight(): boolean { - return false; + return this.children.autoHeight.getView(); } };