From eee976885e600734479c2f0a219784481a1f315a Mon Sep 17 00:00:00 2001 From: RAHEEL Date: Tue, 23 Apr 2024 12:23:01 +0500 Subject: [PATCH 1/3] remove isModule check on page load query trigger --- client/packages/lowcoder/src/comps/queries/queryComp.tsx | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/client/packages/lowcoder/src/comps/queries/queryComp.tsx b/client/packages/lowcoder/src/comps/queries/queryComp.tsx index 8178bac9b..9d894683e 100644 --- a/client/packages/lowcoder/src/comps/queries/queryComp.tsx +++ b/client/packages/lowcoder/src/comps/queries/queryComp.tsx @@ -8,7 +8,7 @@ import DataSourceIcon from "components/DataSourceIcon"; import { SimpleNameComp } from "comps/comps/simpleNameComp"; import { StringControl } from "comps/controls/codeControl"; import { eventHandlerControl } from "comps/controls/eventHandlerControl"; -import { EditorContext, EditorState } from "comps/editorState"; +import { EditorState } from "comps/editorState"; import { stateComp, valueComp, @@ -43,7 +43,7 @@ import { wrapActionExtraInfo, } from "lowcoder-core"; import { ValueFromOption } from "lowcoder-design"; -import { ReactNode, useContext, useEffect } from "react"; +import { ReactNode, useEffect } from "react"; import { BottomResComp, BottomResCompResult, @@ -271,12 +271,10 @@ interface QueryViewProps { } function QueryView(props: QueryViewProps) { - const editorState = useContext(EditorContext); const { comp } = props; useEffect(() => { // Automatically load when page load - if ( getTriggerType(comp) === "automatic" && (comp as any).isDepReady && From a0471c3c63b989ab836a35d04193bd24a24e496a Mon Sep 17 00:00:00 2001 From: RAHEEL Date: Tue, 23 Apr 2024 12:54:05 +0500 Subject: [PATCH 2/3] upgrade styled-components to latest version + fixed targetRef warning from react-resizable-detector --- client/packages/lowcoder/package.json | 2 +- .../lowcoder/src/comps/comps/iconComp.tsx | 32 +++---- .../lowcoder/src/comps/comps/imageComp.tsx | 40 +++++---- .../src/comps/comps/listViewComp/listView.tsx | 25 ++++-- .../comps/comps/meetingComp/controlButton.tsx | 83 ++++++++++--------- .../src/comps/comps/treeComp/treeComp.tsx | 80 +++++++++--------- client/yarn.lock | 4 +- 7 files changed, 145 insertions(+), 121 deletions(-) diff --git a/client/packages/lowcoder/package.json b/client/packages/lowcoder/package.json index 7d39538c1..23f997f97 100644 --- a/client/packages/lowcoder/package.json +++ b/client/packages/lowcoder/package.json @@ -92,7 +92,7 @@ "resize-observer-polyfill": "^1.5.1", "simplebar-react": "^3.2.4", "sql-formatter": "^8.2.0", - "styled-components": "^6.1.6", + "styled-components": "^6.1.8", "stylis": "^4.1.1", "tern": "^0.24.3", "typescript-collections": "^1.3.3", diff --git a/client/packages/lowcoder/src/comps/comps/iconComp.tsx b/client/packages/lowcoder/src/comps/comps/iconComp.tsx index c04c5bbb3..f1700f489 100644 --- a/client/packages/lowcoder/src/comps/comps/iconComp.tsx +++ b/client/packages/lowcoder/src/comps/comps/iconComp.tsx @@ -80,20 +80,24 @@ const IconView = (props: RecordConstructorToView) => { }; return ( - - props.onEvent("click")} - > - {props.icon} - + ( + props.onEvent("click")} + > + {props.icon} + + )} + > ); }; diff --git a/client/packages/lowcoder/src/comps/comps/imageComp.tsx b/client/packages/lowcoder/src/comps/comps/imageComp.tsx index 81d682342..b5a2a5728 100644 --- a/client/packages/lowcoder/src/comps/comps/imageComp.tsx +++ b/client/packages/lowcoder/src/comps/comps/imageComp.tsx @@ -132,24 +132,28 @@ const ContainerImg = (props: RecordConstructorToView) => { } }; return ( - - -
- props.onEvent("click")} - /> -
-
+ ( + +
+ props.onEvent("click")} + /> +
+
+ )} + >
); }; diff --git a/client/packages/lowcoder/src/comps/comps/listViewComp/listView.tsx b/client/packages/lowcoder/src/comps/comps/listViewComp/listView.tsx index da62b232c..0d82ed705 100644 --- a/client/packages/lowcoder/src/comps/comps/listViewComp/listView.tsx +++ b/client/packages/lowcoder/src/comps/comps/listViewComp/listView.tsx @@ -278,15 +278,22 @@ export function ListView(props: Props) { - <>{ { if (height) setListHeight(height); }} observerOptions={{ box: "border-box" }} > - 1} - $autoHeight={autoHeight} - > - {renders} - - } + { + if (height) setListHeight(height); + }} + observerOptions={{ box: "border-box" }} + render={() => ( + 1} + $autoHeight={autoHeight} + > + {renders} + + )} + > + diff --git a/client/packages/lowcoder/src/comps/comps/meetingComp/controlButton.tsx b/client/packages/lowcoder/src/comps/comps/meetingComp/controlButton.tsx index 1a2321a9b..6911b9d0e 100644 --- a/client/packages/lowcoder/src/comps/comps/meetingComp/controlButton.tsx +++ b/client/packages/lowcoder/src/comps/comps/meetingComp/controlButton.tsx @@ -228,54 +228,59 @@ let ButtonTmpComp = (function () { return ( {(editorState) => ( - - -
- ( + +
+ - isDefault(props.type) - ? props.onEvent("click") - : submitForm(editorState, props.form) - } - > - {props.prefixIcon && ( - - {props.prefixIcon} - - )} - -
-
+ } + disabled={ + props.disabled || + (!isDefault(props.type) && + getForm(editorState, props.form)?.disableSubmit()) + } + onClick={() => + isDefault(props.type) + ? props.onEvent("click") + : submitForm(editorState, props.form) + } + > + {props.prefixIcon && ( + + {props.prefixIcon} + + )} + +
+
+
+ )} + >
)}
diff --git a/client/packages/lowcoder/src/comps/comps/treeComp/treeComp.tsx b/client/packages/lowcoder/src/comps/comps/treeComp/treeComp.tsx index 1969bffc2..d6063652f 100644 --- a/client/packages/lowcoder/src/comps/comps/treeComp/treeComp.tsx +++ b/client/packages/lowcoder/src/comps/comps/treeComp/treeComp.tsx @@ -101,45 +101,49 @@ const TreeCompView = (props: RecordConstructorToView) => { labelStyle, inputFieldStyle:props.inputFieldStyle, children: ( - setHeight(h)}> - - { - value.onChange(keys as (string | number)[]); - props.onEvent("change"); - }} - onCheck={(keys) => { - value.onChange(Array.isArray(keys) ? keys as (string | number)[] : keys.checked as (string | number)[]); - props.onEvent("change"); - }} - onExpand={(keys) => { - expanded.onChange(keys as (string | number)[]); - }} - onFocus={() => props.onEvent("focus")} - onBlur={() => props.onEvent("blur")} - /> + setHeight(h)} + render={() => ( + + { + value.onChange(keys as (string | number)[]); + props.onEvent("change"); + }} + onCheck={(keys) => { + value.onChange(Array.isArray(keys) ? keys as (string | number)[] : keys.checked as (string | number)[]); + props.onEvent("change"); + }} + onExpand={(keys) => { + expanded.onChange(keys as (string | number)[]); + }} + onFocus={() => props.onEvent("focus")} + onBlur={() => props.onEvent("blur")} + /> + )} + > ), }); diff --git a/client/yarn.lock b/client/yarn.lock index 43ab0ac7f..74b3ad344 100644 --- a/client/yarn.lock +++ b/client/yarn.lock @@ -13722,7 +13722,7 @@ __metadata: rollup-plugin-visualizer: ^5.9.2 simplebar-react: ^3.2.4 sql-formatter: ^8.2.0 - styled-components: ^6.1.6 + styled-components: ^6.1.8 stylis: ^4.1.1 tern: ^0.24.3 typescript: ^4.8.4 @@ -19066,7 +19066,7 @@ __metadata: languageName: node linkType: hard -"styled-components@npm:^6.1.6": +"styled-components@npm:^6.1.8": version: 6.1.8 resolution: "styled-components@npm:6.1.8" dependencies: From 6d7a6375faa98fc81c9239db6b05a9b270b12200 Mon Sep 17 00:00:00 2001 From: RAHEEL Date: Tue, 23 Apr 2024 15:55:37 +0500 Subject: [PATCH 3/3] fix code-editor hints tooltip hidden issue in bottom panel --- .../packages/lowcoder/src/base/codeEditor/codeEditor.tsx | 4 +++- .../lowcoder/src/pages/editor/bottom/BottomContent.tsx | 8 +++++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/client/packages/lowcoder/src/base/codeEditor/codeEditor.tsx b/client/packages/lowcoder/src/base/codeEditor/codeEditor.tsx index 840b71dc6..594bc3403 100644 --- a/client/packages/lowcoder/src/base/codeEditor/codeEditor.tsx +++ b/client/packages/lowcoder/src/base/codeEditor/codeEditor.tsx @@ -51,8 +51,10 @@ const textStyle = css` export const CodeEditorTooltipContainer = styled.div` // tooltip common .cm-tooltip { - z-index: ${Layers.codeEditorTooltip}; border: 1px solid #d7d9e0; + padding: 5px !important; + margin-top: 5px !important; + height: 120px; } // make sure antd popover in the code editor available .ant-popover { diff --git a/client/packages/lowcoder/src/pages/editor/bottom/BottomContent.tsx b/client/packages/lowcoder/src/pages/editor/bottom/BottomContent.tsx index 5f3cac778..a23355815 100644 --- a/client/packages/lowcoder/src/pages/editor/bottom/BottomContent.tsx +++ b/client/packages/lowcoder/src/pages/editor/bottom/BottomContent.tsx @@ -143,7 +143,13 @@ export const BottomContent = () => { -
+