Skip to content

Commit df8c97c

Browse files
author
FalkWolsky
committed
Fixing Helmet Tags Implementation
1 parent 17abd87 commit df8c97c

File tree

2 files changed

+34
-30
lines changed

2 files changed

+34
-30
lines changed

‎client/packages/lowcoder/src/app.tsx

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -111,21 +111,16 @@ class AppIndex extends React.Component<AppIndexProps, any> {
111111
{<title>{this.props.brandName}</title>}
112112
{<link rel="icon" href={this.props.favicon} />}
113113
<meta name="description" content={trans("productDesc")} />
114-
115-
{isLowCoderDomain && (
116-
<>
117-
{/* setting Meta Attributes to be able for embedding via iframely */}
118-
<meta property="iframely:title" content="Lowcoder" />
119-
<meta property="iframely:description" content="Lowcoder | rapid App & VideoMeeting builder for everyone." />
120-
121-
<link rel="preconnect" href="https://fonts.googleapis.com"/>
122-
<link rel="preconnect" href="https://fonts.gstatic.com" crossOrigin="anonymous"/>
123-
<link href="https://fonts.googleapis.com/css2?family=Ubuntu:ital,wght@0,300;0,400;0,700;1,400&display=swap" rel="stylesheet"/>
124-
{/* embedding analytics of Cleabits */}
125-
<script src="https://tag.clearbitscripts.com/v1/pk_931b51e405557300e6a7c470e8247d5f/tags.js" referrerPolicy="strict-origin-when-cross-origin"></script>
126-
</>
127-
)}
128-
114+
{isLowCoderDomain && [
115+
// Adding Support for iframely to be able to embedd the component explorer in the docu
116+
<meta key="iframely:title" property="iframely:title" content="Lowcoder" />,
117+
<meta key="iframely:description" property="iframely:description" content="Lowcoder | rapid App & VideoMeeting builder for everyone." />,
118+
<link key="preconnect-googleapis" rel="preconnect" href="https://fonts.googleapis.com" />,
119+
<link key="preconnect-gstatic" rel="preconnect" href="https://fonts.gstatic.com" crossOrigin="anonymous" />,
120+
<link key="font-ubuntu" href="https://fonts.googleapis.com/css2?family=Ubuntu:ital,wght@0,300;0,400;0,700;1,400&display=swap" rel="stylesheet" />,
121+
// adding Clearbit Support for Analytics
122+
<script key="clearbit-script" src="https://tag.clearbitscripts.com/v1/pk_931b51e405557300e6a7c470e8247d5f/tags.js" referrerPolicy="strict-origin-when-cross-origin" type="text/javascript"></script>
123+
]}
129124
</Helmet>
130125
<SystemWarning />
131126
<Router history={history}>

‎client/packages/lowcoder/src/pages/editor/editorView.tsx

Lines changed: 24 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -346,20 +346,16 @@ function EditorView(props: EditorViewProps) {
346346
<CustomShortcutWrapper>
347347
<Helmet>
348348
{application && <title>{application.name}</title>}
349-
{isLowCoderDomain && (
350-
<>
351-
{/* setting Meta Attributes to be able for embedding via iframely */}
352-
<meta property="iframely:title" content="Lowcoder" />
353-
<meta property="iframely:description" content="Lowcoder | rapid App & VideoMeeting builder for everyone." />
354-
355-
<link rel="preconnect" href="https://fonts.googleapis.com"/>
356-
<link rel="preconnect" href="https://fonts.gstatic.com" crossOrigin="anonymous"/>
357-
<link href="https://fonts.googleapis.com/css2?family=Ubuntu:ital,wght@0,300;0,400;0,700;1,400&display=swap" rel="stylesheet"/>
358-
{/* embedding analytics of Cleabits */}
359-
<script src="https://tag.clearbitscripts.com/v1/pk_931b51e405557300e6a7c470e8247d5f/tags.js" referrerPolicy="strict-origin-when-cross-origin"></script>
360-
</>
361-
)}
362-
{application && <title>{application.name}</title>}
349+
{isLowCoderDomain && [
350+
// Adding Support for iframely to be able to embedd the component explorer in the docu
351+
<meta key="iframely:title" property="iframely:title" content="Lowcoder" />,
352+
<meta key="iframely:description" property="iframely:description" content="Lowcoder | rapid App & VideoMeeting builder for everyone." />,
353+
<link key="preconnect-googleapis" rel="preconnect" href="https://fonts.googleapis.com" />,
354+
<link key="preconnect-gstatic" rel="preconnect" href="https://fonts.gstatic.com" crossOrigin="anonymous" />,
355+
<link key="font-ubuntu" href="https://fonts.googleapis.com/css2?family=Ubuntu:ital,wght@0,300;0,400;0,700;1,400&display=swap" rel="stylesheet" />,
356+
// adding Clearbit Support for Analytics
357+
<script key="clearbit-script" src="https://tag.clearbitscripts.com/v1/pk_931b51e405557300e6a7c470e8247d5f/tags.js" referrerPolicy="strict-origin-when-cross-origin" type="text/javascript"></script>
358+
]}
363359
</Helmet>
364360
{!hideBodyHeader && <PreviewHeader />}
365361
<EditorContainerWithViewMode>
@@ -373,6 +369,7 @@ function EditorView(props: EditorViewProps) {
373369
</CustomShortcutWrapper>
374370
);
375371
}
372+
376373
// history mode, display with the right panel, a little trick
377374
const showRight = panelStatus.right || showAppSnapshot;
378375
let uiCompView;
@@ -411,7 +408,19 @@ function EditorView(props: EditorViewProps) {
411408
toggleEditorModeStatus={toggleEditorModeStatus}
412409
editorModeStatus={editorModeStatus}
413410
/>
414-
<Helmet>{application && <title>{application.name}</title>}</Helmet>
411+
<Helmet>
412+
{application && <title>{application.name}</title>}
413+
{isLowCoderDomain && [
414+
// Adding Support for iframely to be able to embedd the component explorer in the docu
415+
<meta key="iframely:title" property="iframely:title" content="Lowcoder" />,
416+
<meta key="iframely:description" property="iframely:description" content="Lowcoder | rapid App & VideoMeeting builder for everyone." />,
417+
<link key="preconnect-googleapis" rel="preconnect" href="https://fonts.googleapis.com" />,
418+
<link key="preconnect-gstatic" rel="preconnect" href="https://fonts.gstatic.com" crossOrigin="anonymous" />,
419+
<link key="font-ubuntu" href="https://fonts.googleapis.com/css2?family=Ubuntu:ital,wght@0,300;0,400;0,700;1,400&display=swap" rel="stylesheet" />,
420+
// adding Clearbit Support for Analytics
421+
<script key="clearbit-script" src="https://tag.clearbitscripts.com/v1/pk_931b51e405557300e6a7c470e8247d5f/tags.js" referrerPolicy="strict-origin-when-cross-origin" type="text/javascript"></script>
422+
]}
423+
</Helmet>
415424
{showNewUserGuide && <EditorTutorials />}
416425
<EditorGlobalHotKeys
417426
disabled={readOnly}

0 commit comments

Comments
 (0)