Skip to content

Commit d12d09d

Browse files
authored
Merge pull request #1344 from lowcoder-org/fix/pagination
Fixed pagination start value
2 parents 6bf8b1c + 3cf31b6 commit d12d09d

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

server/api-service/lowcoder-domain/src/main/java/org/lowcoder/domain/organization/service/OrgMemberServiceImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public Flux<OrgMember> getOrganizationMembers(String orgId) {
5353

5454
@Override
5555
public Flux<OrgMember> getOrganizationMembers(String orgId, int page, int count) {
56-
return biRelationService.getBySourceId(ORG_MEMBER, orgId, PageRequest.of(page, count))
56+
return biRelationService.getBySourceId(ORG_MEMBER, orgId, PageRequest.of(page - 1, count))
5757
.map(OrgMember::from);
5858
}
5959

server/api-service/lowcoder-server/src/main/java/org/lowcoder/api/usermanagement/GroupApiServiceImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ public Mono<GroupMemberAggregateView> getGroupMembers(String groupId, int page,
9898
.filter(Objects::nonNull)
9999
.toList();
100100
var pageTotal = list.size();
101-
list = list.subList(page * count, Math.min(page * count + count, pageTotal));
101+
list = list.subList((page - 1) * count, count == 0 ? pageTotal : Math.min(page * count, pageTotal));
102102
return Pair.of(list, pageTotal);
103103
});
104104
})

server/api-service/lowcoder-server/src/main/java/org/lowcoder/api/usermanagement/GroupController.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,15 +99,15 @@ public Mono<GroupListResponseView<List<GroupView>>> getOrgGroups(@RequestParam(r
9999
.filter(orgMember -> !orgMember.isAdmin() && !orgMember.isSuperAdmin() &&
100100
devMembers.stream().noneMatch(devMember -> devMember.getUserId().equals(orgMember.getUserId()))).toList().size();
101101

102-
var subList = groupList.subList((pageNum - 1) * pageSize, pageSize <= 0?groupList.size():pageNum * pageSize);
102+
var subList = groupList.subList((pageNum - 1) * pageSize, pageSize <= 0?groupList.size():Math.min(pageNum * pageSize, groupList.size()));
103103
return new GroupListResponseView<>(ResponseView.SUCCESS,
104104
"",
105105
subList,
106106
totalAdmins,
107107
totalAdminsAndDevelopers,
108108
totalDevelopersOnly,
109109
totalOtherMembers,
110-
subList.size(),
110+
groupList.size(),
111111
pageNum,
112112
pageSize);
113113
})

server/api-service/lowcoder-server/src/main/java/org/lowcoder/api/usermanagement/OrgApiServiceImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ private Mono<OrgMemberListView> getOrgMemberListView(String orgId, int page, int
106106
.filter(Objects::nonNull)
107107
.collect(Collectors.toList());
108108
var pageTotal = list.size();
109-
list = list.subList(page * count, Math.min(page * count + count, pageTotal));
109+
list = list.subList((page - 1) * count, count == 0 ? pageTotal : Math.min(page * count, pageTotal));
110110
return Pair.of(list, pageTotal);
111111
});
112112
})

0 commit comments

Comments
 (0)