Skip to content

Commit 3ad5240

Browse files
dragonpooludomikula
authored andcommitted
Updated deleted app
1 parent f3b1feb commit 3ad5240

File tree

5 files changed

+9
-8
lines changed

5 files changed

+9
-8
lines changed

server/api-service/lowcoder-server/src/main/java/org/lowcoder/api/application/ApplicationApiService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public interface ApplicationApiService {
3434

3535
Mono<Void> updateUserApplicationLastViewTime(String applicationId);
3636

37-
Mono<ApplicationView> update(String applicationId, Application application);
37+
Mono<ApplicationView> update(String applicationId, Application application, Boolean updateStatus);
3838

3939
Mono<ApplicationView> publish(String applicationId, ApplicationPublishRequest applicationPublishRequest);
4040

server/api-service/lowcoder-server/src/main/java/org/lowcoder/api/application/ApplicationApiServiceImpl.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -346,23 +346,24 @@ public Mono<Void> updateUserApplicationLastViewTime(String applicationId) {
346346
}
347347

348348
@Override
349-
public Mono<ApplicationView> update(String applicationId, Application application) {
350-
return checkApplicationStatus(applicationId, NORMAL)
349+
public Mono<ApplicationView> update(String applicationId, Application application, Boolean updateStatus) {
350+
return Boolean.TRUE.equals(updateStatus) ? Mono.empty() : checkApplicationStatus(applicationId, NORMAL)
351351
.then(sessionUserService.getVisitorId())
352352
.flatMap(userId -> resourcePermissionService.checkAndReturnMaxPermission(userId,
353353
applicationId, EDIT_APPLICATIONS))
354354
.delayUntil(__ -> checkDatasourcePermissions(application))
355-
.flatMap(permission -> doUpdateApplication(applicationId, application)
355+
.flatMap(permission -> doUpdateApplication(applicationId, application, updateStatus)
356356
.flatMap(applicationUpdated -> buildView(applicationUpdated, permission.getResourceRole().getValue()).map(appInfoView -> ApplicationView.builder()
357357
.applicationInfoView(appInfoView)
358358
.applicationDSL(applicationUpdated.getEditingApplicationDSL())
359359
.build())));
360360
}
361361

362-
private Mono<Application> doUpdateApplication(String applicationId, Application application) {
362+
private Mono<Application> doUpdateApplication(String applicationId, Application application, Boolean updateStatus) {
363363
Application applicationUpdate = Application.builder()
364364
.editingApplicationDSL(application.getEditingApplicationDSLOrNull())
365365
.name(application.getName())
366+
.applicationStatus(Boolean.TRUE.equals(updateStatus) ? application.getApplicationStatus() : null)
366367
.build();
367368
return applicationService.updateById(applicationId, applicationUpdate)
368369
.then(applicationService.findById(applicationId));

server/api-service/lowcoder-server/src/main/java/org/lowcoder/api/application/ApplicationController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ public Mono<ResponseView<ApplicationView>> update(@PathVariable String applicati
123123
@RequestBody Application newApplication,
124124
@RequestParam(required = false) Boolean updateStatus) {
125125
return gidService.convertApplicationIdToObjectId(applicationId).flatMap(appId ->
126-
applicationApiService.update(appId, newApplication)
126+
applicationApiService.update(appId, newApplication, updateStatus)
127127
.delayUntil(applicationView -> businessEventPublisher.publishApplicationCommonEvent(applicationView, APPLICATION_UPDATE))
128128
.map(ResponseView::success));
129129
}

server/api-service/lowcoder-server/src/test/java/org/lowcoder/api/application/ApplicationApiServiceIntegrationTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ public void testUpdateApplicationFailedDueToLackOfDatasourcePermissions() {
116116
.editingApplicationDSL(applicationView.getApplicationDSL())
117117
.name("app03")
118118
.build();
119-
return applicationApiService.update(applicationView.getApplicationInfoView().getApplicationId(), application);
119+
return applicationApiService.update(applicationView.getApplicationInfoView().getApplicationId(), application, false);
120120
});
121121

122122
StepVerifier.create(applicationViewMono)

server/api-service/lowcoder-server/src/test/java/org/lowcoder/api/application/ApplicationApiServiceTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ public void testPublishApplication() {
169169

170170
// update
171171
applicationIdMono = applicationIdMono
172-
.delayUntil(id -> applicationApiService.update(id, Application.builder().editingApplicationDSL(Map.of("comp", "table")).build())).cache();
172+
.delayUntil(id -> applicationApiService.update(id, Application.builder().editingApplicationDSL(Map.of("comp", "table")).build(), false)).cache();
173173

174174
// edit dsl after publish
175175
StepVerifier.create(applicationIdMono.flatMap(id -> applicationApiService.getEditingApplication(id, false)))

0 commit comments

Comments
 (0)