Skip to content

Commit 2012c8c

Browse files
Thomasrludomikula
Thomasr
authored andcommitted
Fix testcase error
1 parent 67bde07 commit 2012c8c

File tree

4 files changed

+12
-7
lines changed

4 files changed

+12
-7
lines changed

server/api-service/lowcoder-domain/src/main/java/org/lowcoder/domain/application/service/impl/ApplicationHistorySnapshotServiceImpl.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import static org.lowcoder.sdk.util.ExceptionUtils.deferredError;
55
import static org.lowcoder.sdk.util.ExceptionUtils.ofException;
66

7+
import java.time.Instant;
78
import java.util.List;
89
import java.util.Map;
910

@@ -60,6 +61,10 @@ public Mono<ApplicationHistorySnapshot> getHistorySnapshotDetail(String historyS
6061

6162
@Override
6263
public Mono<ApplicationHistorySnapshot> getLastSnapshotByApp(String applicationId) {
63-
return repository.findAllByApplicationId(applicationId, PageRequest.of(0, 1).withSort(Direction.DESC, "createdAt")).last();
64+
ApplicationHistorySnapshot _default = new ApplicationHistorySnapshot();
65+
_default.setCreatedAt(Instant.ofEpochMilli(0));
66+
_default.setCreatedBy("");
67+
return repository.findAllByApplicationId(applicationId, PageRequest.of(0, 1).withSort(Direction.DESC, "createdAt"))
68+
.switchIfEmpty(Mono.just(_default)).next();
6469
}
6570
}

server/api-service/lowcoder-server/src/test/java/org/lowcoder/api/application/ApplicationApiServiceIntegrationTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,12 +131,12 @@ public void testUpdateApplicationFailedDueToLackOfDatasourcePermissions() {
131131
@Test
132132
@WithMockUser
133133
public void testUpdateEditingStateSuccess() {
134-
Mono<ApplicationView> applicationViewMono = applicationApiService.create(new CreateApplicationRequest("org01", "app1", ApplicationType.APPLICATION.getValue(), null, null, null));
134+
Mono<ApplicationView> applicationViewMono = applicationApiService.create(new CreateApplicationRequest("org01", "app1", ApplicationType.APPLICATION.getValue(), Map.of("comp", "table"), Map.of("comp", "list"), null));
135135
Mono<ApplicationView> updateEditStateMono = applicationViewMono.delayUntil(app -> applicationApiService.updateEditState(app.getApplicationInfoView().getApplicationId(), new ApplicationEndpoints.UpdateEditStateRequest(true)));
136136
Mono<ApplicationView> app = updateEditStateMono.flatMap(applicationView -> applicationApiService.getEditingApplication(applicationView.getApplicationInfoView().getApplicationId()));
137137
StepVerifier.create(app)
138138
.assertNext(application -> {
139-
Assertions.assertEquals("", application.getApplicationInfoView().getEditingUserId());
139+
Assertions.assertEquals("user01", application.getApplicationInfoView().getEditingUserId());
140140
})
141141
.verifyComplete();
142142
}

server/api-service/lowcoder-server/src/test/java/org/lowcoder/api/common/InitData.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,6 @@ public class InitData {
3131
public void init() {
3232
try {
3333
execute();
34-
} catch (DuplicateKeyException ignored) {
35-
3634
} catch (Exception e) {
3735
throw new RuntimeException(e);
3836
}

server/api-service/lowcoder-server/src/test/java/org/lowcoder/api/common/json/group.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,15 @@
66
"name": "Develops",
77
"organizationId": "org01",
88
"allUsersGroup": false,
9-
"type": "dev"
9+
"type": "dev",
10+
"gid": "01916999-a508-7b61-bba9-e27f2427396a"
1011
},
1112
{
1213
"id": "group01",
1314
"name": "group01",
1415
"organizationId": "org01",
15-
"allUsersGroup": false
16+
"allUsersGroup": false,
17+
"gid": "01916999-d8ee-786b-a00f-22b52fe59224"
1618
}
1719
]
1820
}

0 commit comments

Comments
 (0)