Skip to content

Commit 1fb8303

Browse files
committed
Merge branch 'oauth_pr' into feat-generic-oauth
# Conflicts: # server/api-service/lowcoder-sdk/src/main/java/org/lowcoder/sdk/auth/Oauth2GenericAuthConfig.java # server/api-service/lowcoder-server/src/main/java/org/lowcoder/api/authentication/dto/AuthConfigRequest.java # server/api-service/lowcoder-server/src/main/java/org/lowcoder/api/authentication/service/factory/AuthConfigFactoryImpl.java
2 parents 91779ce + 528f77b commit 1fb8303

File tree

5 files changed

+11
-7
lines changed

5 files changed

+11
-7
lines changed

server/api-service/lowcoder-sdk/src/main/java/org/lowcoder/sdk/auth/Oauth2GenericAuthConfig.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,5 @@ public class Oauth2GenericAuthConfig extends Oauth2SimpleAuthConfig {
1515
private String authorizationEndpoint;
1616
private String tokenEndpoint;
1717
private String userInfoEndpoint;
18+
private String scope;
1819
}

server/api-service/lowcoder-sdk/src/main/java/org/lowcoder/sdk/config/CommonConfig.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,8 +141,8 @@ public static class Workspace {
141141

142142
@Data
143143
public static class Cookie {
144-
145-
private long maxAgeInSeconds = Duration.ofDays(30).toSeconds();
144+
//Set cookie max age to 1 day
145+
private long maxAgeInSeconds = Duration.ofDays(1).toSeconds();
146146
}
147147

148148
@Data

server/api-service/lowcoder-server/src/main/java/org/lowcoder/api/authentication/dto/AuthConfigRequest.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public boolean isEnableRegister() {
3434
*/
3535
@Nullable
3636
public String getIssuerUri() {
37-
return getString("issuer");
37+
return getString("issuerUri");
3838
}
3939

4040
@Nullable
@@ -67,6 +67,11 @@ public String getClientSecret() {
6767
return getString("clientSecret");
6868
}
6969

70+
@Nullable
71+
public String getScope() {
72+
return getString("scope");
73+
}
74+
7075
public String getSource(String defaultValue) {
7176
String source = getString("source");
7277
if (StringUtils.isNotBlank(source)) {

server/api-service/lowcoder-server/src/main/java/org/lowcoder/api/authentication/service/factory/AuthConfigFactoryImpl.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,7 @@ private Oauth2SimpleAuthConfig buildOauth2GenericAuthConfig(AuthConfigRequest au
112112
.authorizationEndpoint(authConfigRequest.getAuthorizationEndpoint())
113113
.tokenEndpoint(authConfigRequest.getTokenEndpoint())
114114
.userInfoEndpoint(authConfigRequest.getUserInfoEndpoint())
115+
.scope(authConfigRequest.getScope())
115116
.authType(AuthTypeConstants.GENERIC)
116117
.build();
117118
}

server/api-service/lowcoder-server/src/main/java/org/lowcoder/api/home/SessionUserServiceImpl.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -118,10 +118,7 @@ public Mono<Void> extendValidity(String token) {
118118

119119
private Duration getTokenExpireTime() {
120120
long maxAgeInSeconds = commonConfig.getCookie().getMaxAgeInSeconds();
121-
if (maxAgeInSeconds >= 0) {
122-
return Duration.ofSeconds(maxAgeInSeconds).plus(Duration.ofDays(1));
123-
}
124-
return Duration.ofDays(7);
121+
return Duration.ofSeconds(maxAgeInSeconds);
125122
}
126123

127124
@Override

0 commit comments

Comments
 (0)