Skip to content

Commit f06f016

Browse files
committed
[clang-format][NFC] Add missing parens of __attribute in unit tests
1 parent 80303cb commit f06f016

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

clang/unittests/Format/FormatTest.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14928,7 +14928,7 @@ TEST_F(FormatTest, UnderstandContextOfRecordTypeKeywords) {
1492814928
verifyFormat("union Z {\n int n;\n} x;");
1492914929
verifyFormat("class MACRO Z {\n} n;");
1493014930
verifyFormat("class MACRO(X) Z {\n} n;");
14931-
verifyFormat("class __attribute__(X) Z {\n} n;");
14931+
verifyFormat("class __attribute__((X)) Z {\n} n;");
1493214932
verifyFormat("class __declspec(X) Z {\n} n;");
1493314933
verifyFormat("class A##B##C {\n} n;");
1493414934
verifyFormat("class alignas(16) Z {\n} n;");

clang/unittests/Format/TokenAnnotatorTest.cpp

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1994,11 +1994,11 @@ TEST_F(TokenAnnotatorTest, UnderstandHashInMacro) {
19941994

19951995
TEST_F(TokenAnnotatorTest, UnderstandsAttributeMacros) {
19961996
// '__attribute__' has special handling.
1997-
auto Tokens = annotate("__attribute__(X) void Foo(void);");
1998-
ASSERT_EQ(Tokens.size(), 11u) << Tokens;
1997+
auto Tokens = annotate("__attribute__((X)) void Foo(void);");
1998+
ASSERT_EQ(Tokens.size(), 13u) << Tokens;
19991999
EXPECT_TOKEN(Tokens[0], tok::kw___attribute, TT_Unknown);
20002000
EXPECT_TOKEN(Tokens[1], tok::l_paren, TT_AttributeLParen);
2001-
EXPECT_TOKEN(Tokens[3], tok::r_paren, TT_AttributeRParen);
2001+
EXPECT_TOKEN(Tokens[5], tok::r_paren, TT_AttributeRParen);
20022002

20032003
// Generic macro has no special handling in this location.
20042004
Tokens = annotate("A(X) void Foo(void);");
@@ -2020,11 +2020,11 @@ TEST_F(TokenAnnotatorTest, UnderstandsAttributeMacros) {
20202020

20212021
TEST_F(TokenAnnotatorTest, UnderstandsAttributeMacrosOnObjCDecl) {
20222022
// '__attribute__' has special handling.
2023-
auto Tokens = annotate("__attribute__(X) @interface Foo");
2024-
ASSERT_EQ(Tokens.size(), 8u) << Tokens;
2023+
auto Tokens = annotate("__attribute__((X)) @interface Foo");
2024+
ASSERT_EQ(Tokens.size(), 10u) << Tokens;
20252025
EXPECT_TOKEN(Tokens[0], tok::kw___attribute, TT_Unknown);
20262026
EXPECT_TOKEN(Tokens[1], tok::l_paren, TT_AttributeLParen);
2027-
EXPECT_TOKEN(Tokens[3], tok::r_paren, TT_AttributeRParen);
2027+
EXPECT_TOKEN(Tokens[5], tok::r_paren, TT_AttributeRParen);
20282028

20292029
// Generic macro has no special handling in this location.
20302030
Tokens = annotate("A(X) @interface Foo");
@@ -2048,11 +2048,11 @@ TEST_F(TokenAnnotatorTest, UnderstandsAttributeMacrosOnObjCDecl) {
20482048

20492049
TEST_F(TokenAnnotatorTest, UnderstandsAttributeMacrosOnObjCMethodDecl) {
20502050
// '__attribute__' has special handling.
2051-
auto Tokens = annotate("- (id)init __attribute__(X);");
2052-
ASSERT_EQ(Tokens.size(), 11u) << Tokens;
2051+
auto Tokens = annotate("- (id)init __attribute__((X));");
2052+
ASSERT_EQ(Tokens.size(), 13u) << Tokens;
20532053
EXPECT_TOKEN(Tokens[5], tok::kw___attribute, TT_Unknown);
20542054
EXPECT_TOKEN(Tokens[6], tok::l_paren, TT_AttributeLParen);
2055-
EXPECT_TOKEN(Tokens[8], tok::r_paren, TT_AttributeRParen);
2055+
EXPECT_TOKEN(Tokens[10], tok::r_paren, TT_AttributeRParen);
20562056

20572057
// Generic macro has no special handling in this location.
20582058
Tokens = annotate("- (id)init A(X);");
@@ -2076,11 +2076,11 @@ TEST_F(TokenAnnotatorTest, UnderstandsAttributeMacrosOnObjCMethodDecl) {
20762076

20772077
TEST_F(TokenAnnotatorTest, UnderstandsAttributeMacrosOnObjCProperty) {
20782078
// '__attribute__' has special handling.
2079-
auto Tokens = annotate("@property(weak) id delegate __attribute__(X);");
2080-
ASSERT_EQ(Tokens.size(), 13u) << Tokens;
2079+
auto Tokens = annotate("@property(weak) id delegate __attribute__((X));");
2080+
ASSERT_EQ(Tokens.size(), 15u) << Tokens;
20812081
EXPECT_TOKEN(Tokens[7], tok::kw___attribute, TT_Unknown);
20822082
EXPECT_TOKEN(Tokens[8], tok::l_paren, TT_AttributeLParen);
2083-
EXPECT_TOKEN(Tokens[10], tok::r_paren, TT_AttributeRParen);
2083+
EXPECT_TOKEN(Tokens[12], tok::r_paren, TT_AttributeRParen);
20842084

20852085
// Generic macro has no special handling in this location.
20862086
Tokens = annotate("@property(weak) id delegate A(X);");

0 commit comments

Comments
 (0)