Skip to content

Commit de03e10

Browse files
pedroclobopedroclobo
authored
[DirectX] Change placeholders from undef to poison used in fully instantiated vector [NFC] (#130970)
1 parent f4043f4 commit de03e10

File tree

5 files changed

+12
-12
lines changed

5 files changed

+12
-12
lines changed

‎llvm/lib/Target/DirectX/DXILIntrinsicExpansion.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ static Value *expandCrossIntrinsic(CallInst *Orig) {
147147
Value *zx_xz = MulSub(op0_z, op0_x, op1_z, op1_x);
148148
Value *xy_yx = MulSub(op0_x, op0_y, op1_x, op1_y);
149149

150-
Value *cross = UndefValue::get(VT);
150+
Value *cross = PoisonValue::get(VT);
151151
cross = Builder.CreateInsertElement(cross, yz_zy, (uint64_t)0);
152152
cross = Builder.CreateInsertElement(cross, zx_xz, 1);
153153
cross = Builder.CreateInsertElement(cross, xy_yx, 2);

‎llvm/lib/Target/DirectX/DXILOpLowering.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -482,7 +482,7 @@ class OpLowerer {
482482
if (!Extracts[I])
483483
Extracts[I] = IRB.CreateExtractValue(Op, I);
484484

485-
Value *Vec = UndefValue::get(OldTy);
485+
Value *Vec = PoisonValue::get(OldTy);
486486
for (int I = 0, E = N; I != E; ++I)
487487
Vec = IRB.CreateInsertElement(Vec, Extracts[I], I);
488488
OldResult->replaceAllUsesWith(Vec);

‎llvm/test/CodeGen/DirectX/BufferLoad.ll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ define void @loadv4f32() {
4343
; CHECK: extractvalue %dx.types.ResRet.f32 [[DATA4]], 1
4444
; CHECK: extractvalue %dx.types.ResRet.f32 [[DATA4]], 2
4545
; CHECK: extractvalue %dx.types.ResRet.f32 [[DATA4]], 3
46-
; CHECK: insertelement <4 x float> undef
46+
; CHECK: insertelement <4 x float> poison
4747
; CHECK: insertelement <4 x float>
4848
; CHECK: insertelement <4 x float>
4949
; CHECK: insertelement <4 x float>

‎llvm/test/CodeGen/DirectX/RawBufferLoad.ll

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ define void @loadv4f32_struct(i32 %index) {
6969
; CHECK: extractvalue %dx.types.ResRet.f32 [[DATA]], 1
7070
; CHECK: extractvalue %dx.types.ResRet.f32 [[DATA]], 2
7171
; CHECK: extractvalue %dx.types.ResRet.f32 [[DATA]], 3
72-
; CHECK: insertelement <4 x float> undef
72+
; CHECK: insertelement <4 x float> poison
7373
; CHECK: insertelement <4 x float>
7474
; CHECK: insertelement <4 x float>
7575
; CHECK: insertelement <4 x float>
@@ -97,7 +97,7 @@ define void @loadv4f32_byte(i32 %offset) {
9797
; CHECK: extractvalue %dx.types.ResRet.f32 [[DATA]], 1
9898
; CHECK: extractvalue %dx.types.ResRet.f32 [[DATA]], 2
9999
; CHECK: extractvalue %dx.types.ResRet.f32 [[DATA]], 3
100-
; CHECK: insertelement <4 x float> undef
100+
; CHECK: insertelement <4 x float> poison
101101
; CHECK: insertelement <4 x float>
102102
; CHECK: insertelement <4 x float>
103103
; CHECK: insertelement <4 x float>
@@ -125,7 +125,7 @@ define void @loadelements(i32 %index) {
125125
; CHECK: extractvalue %dx.types.ResRet.f32 [[DATAF32]], 1
126126
; CHECK: extractvalue %dx.types.ResRet.f32 [[DATAF32]], 2
127127
; CHECK: extractvalue %dx.types.ResRet.f32 [[DATAF32]], 3
128-
; CHECK: insertelement <4 x float> undef
128+
; CHECK: insertelement <4 x float> poison
129129
; CHECK: insertelement <4 x float>
130130
; CHECK: insertelement <4 x float>
131131
; CHECK: insertelement <4 x float>
@@ -144,7 +144,7 @@ define void @loadelements(i32 %index) {
144144
; CHECK: extractvalue %dx.types.ResRet.i32 [[DATAI32]], 1
145145
; CHECK: extractvalue %dx.types.ResRet.i32 [[DATAI32]], 2
146146
; CHECK: extractvalue %dx.types.ResRet.i32 [[DATAI32]], 3
147-
; CHECK: insertelement <4 x i32> undef
147+
; CHECK: insertelement <4 x i32> poison
148148
; CHECK: insertelement <4 x i32>
149149
; CHECK: insertelement <4 x i32>
150150
; CHECK: insertelement <4 x i32>
@@ -180,7 +180,7 @@ define void @loadnested(i32 %index) {
180180
; CHECK: extractvalue %dx.types.ResRet.f32 [[DATAF32]], 1
181181
; CHECK: extractvalue %dx.types.ResRet.f32 [[DATAF32]], 2
182182
; CHECK: extractvalue %dx.types.ResRet.f32 [[DATAF32]], 3
183-
; CHECK: insertelement <4 x float> undef
183+
; CHECK: insertelement <4 x float> poison
184184
; CHECK: insertelement <4 x float>
185185
; CHECK: insertelement <4 x float>
186186
; CHECK: insertelement <4 x float>
@@ -196,7 +196,7 @@ define void @loadnested(i32 %index) {
196196
; CHECK: extractvalue %dx.types.ResRet.f16 [[DATAF16]], 0
197197
; CHECK: extractvalue %dx.types.ResRet.f16 [[DATAF16]], 1
198198
; CHECK: extractvalue %dx.types.ResRet.f16 [[DATAF16]], 2
199-
; CHECK: insertelement <3 x half> undef
199+
; CHECK: insertelement <3 x half> poison
200200
; CHECK: insertelement <3 x half>
201201
; CHECK: insertelement <3 x half>
202202
; CHECK: call void @v3f16_user(<3 x half>
@@ -221,7 +221,7 @@ define void @loadv4f64_byte(i32 %offset) {
221221
; CHECK: extractvalue %dx.types.ResRet.f64 [[DATA]], 1
222222
; CHECK: extractvalue %dx.types.ResRet.f64 [[DATA]], 2
223223
; CHECK: extractvalue %dx.types.ResRet.f64 [[DATA]], 3
224-
; CHECK: insertelement <4 x double> undef
224+
; CHECK: insertelement <4 x double> poison
225225
; CHECK: insertelement <4 x double>
226226
; CHECK: insertelement <4 x double>
227227
; CHECK: insertelement <4 x double>

‎llvm/test/CodeGen/DirectX/cross.ll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ entry:
2222
; CHECK: %4 = fmul half %x0, %y1
2323
; CHECK: %5 = fmul half %x1, %y0
2424
; CHECK: %hlsl.cross3 = fsub half %4, %5
25-
; CHECK: %6 = insertelement <3 x half> undef, half %hlsl.cross1, i64 0
25+
; CHECK: %6 = insertelement <3 x half> poison, half %hlsl.cross1, i64 0
2626
; CHECK: %7 = insertelement <3 x half> %6, half %hlsl.cross2, i64 1
2727
; CHECK: %8 = insertelement <3 x half> %7, half %hlsl.cross3, i64 2
2828
; CHECK: ret <3 x half> %8
@@ -47,7 +47,7 @@ entry:
4747
; CHECK: %4 = fmul float %x0, %y1
4848
; CHECK: %5 = fmul float %x1, %y0
4949
; CHECK: %hlsl.cross3 = fsub float %4, %5
50-
; CHECK: %6 = insertelement <3 x float> undef, float %hlsl.cross1, i64 0
50+
; CHECK: %6 = insertelement <3 x float> poison, float %hlsl.cross1, i64 0
5151
; CHECK: %7 = insertelement <3 x float> %6, float %hlsl.cross2, i64 1
5252
; CHECK: %8 = insertelement <3 x float> %7, float %hlsl.cross3, i64 2
5353
; CHECK: ret <3 x float> %8

0 commit comments

Comments
 (0)