Skip to content

Commit d09231a

Browse files
authored
[lldb/crashlog] Remove aarch64 requirement on crashlog tests (#94553)
This PR removes the `target-aarch64` requirement on the crashlog tests to exercice them on Intel bots and make image loading single-threaded temporarily while implementing a fix for a deadlock issue when loading the images in parallel. Signed-off-by: Med Ismail Bennani <ismail@bennani.ma>
1 parent 5d0308f commit d09231a

8 files changed

+12
-6
lines changed

lldb/examples/python/crashlog.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1814,6 +1814,9 @@ def SymbolicateCrashLogs(debugger, command_args, result, is_command):
18141814
)
18151815
)
18161816

1817+
if "NO_PARALLEL_IMG_LOADING" in os.environ:
1818+
options.no_parallel_image_loading = True
1819+
18171820
if options.version:
18181821
print(debugger.GetVersionString())
18191822
return

lldb/test/Shell/ScriptInterpreter/Python/Crashlog/app_specific_backtrace_crashlog.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# REQUIRES: python, native && target-aarch64 && system-darwin
1+
# REQUIRES: python, native && system-darwin
22

33
# RUN: mkdir -p %t.dir
44
# RUN: yaml2obj %S/Inputs/application_specific_info/asi.yaml > %t.dir/asi

lldb/test/Shell/ScriptInterpreter/Python/Crashlog/interactive_crashlog_invalid_target.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# REQUIRES: python, native && target-aarch64 && system-darwin
1+
# REQUIRES: python, native && system-darwin
22

33
# RUN: %lldb -o 'command script import lldb.macosx.crashlog' \
44
# RUN: -o 'crashlog -V' \

lldb/test/Shell/ScriptInterpreter/Python/Crashlog/interactive_crashlog_json.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# REQUIRES: python, native && target-aarch64 && system-darwin
1+
# REQUIRES: python, native && system-darwin
22

33
# RUN: mkdir -p %t.dir
44
# RUN: yaml2obj %S/Inputs/interactive_crashlog/multithread-test.yaml > %t.dir/multithread-test

lldb/test/Shell/ScriptInterpreter/Python/Crashlog/interactive_crashlog_legacy.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# REQUIRES: python, native && target-aarch64 && system-darwin
1+
# REQUIRES: python, native && system-darwin
22

33
# RUN: mkdir -p %t.dir
44
# RUN: yaml2obj %S/Inputs/interactive_crashlog/multithread-test.yaml > %t.dir/multithread-test

lldb/test/Shell/ScriptInterpreter/Python/Crashlog/last_exception_backtrace_crashlog.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# REQUIRES: python, native && target-aarch64 && system-darwin
1+
# REQUIRES: python, native && system-darwin
22

33
# RUN: mkdir -p %t.dir
44
# RUN: yaml2obj %S/Inputs/application_specific_info/asi.yaml > %t.dir/asi

lldb/test/Shell/ScriptInterpreter/Python/Crashlog/lit.local.cfg

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,6 @@ if 'lldb-repro' in config.available_features:
55
config.unsupported = True
66

77
config.environment["LLDB_APPLE_DSYMFORUUID_EXECUTABLE"] = ""
8+
9+
# Temporary parallel image loading deadlock workaround
10+
config.environment["NO_PARALLEL_IMG_LOADING"] = ""

lldb/test/Shell/ScriptInterpreter/Python/Crashlog/skipped_status_interactive_crashlog.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# REQUIRES: python, native && target-aarch64 && system-darwin
1+
# REQUIRES: python, native && system-darwin
22

33
# RUN: mkdir -p %t.dir
44
# RUN: yaml2obj %S/Inputs/interactive_crashlog/multithread-test.yaml > %t.dir/multithread-test

0 commit comments

Comments
 (0)