Skip to content

Commit a867aa7

Browse files
committed
[clang][Darwin] Simply deployment version assignment in the Driver
To be able to handle all of the ways the platform & deployment version can be represented in command line flags, the darwin toolchain holds a type `DarwinPlatform` to help represent them. This patch simplifes the logic by simplifying the number of conversions between string & version tuples and renaming variables to reduce confusion of what target triple inforomation is being manipulated.
1 parent 540cf25 commit a867aa7

File tree

4 files changed

+166
-125
lines changed

4 files changed

+166
-125
lines changed

clang/include/clang/Basic/DiagnosticDriverKinds.td

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,8 @@ def err_drv_cannot_open_randomize_layout_seed_file : Error<
206206
"cannot read randomize layout seed file '%0'">;
207207
def err_drv_invalid_version_number : Error<
208208
"invalid version number in '%0'">;
209+
def err_drv_missing_version_number : Error<
210+
"missing version number in '%0'">;
209211
def err_drv_kcfi_arity_unsupported_target : Error<
210212
"target '%0' is unsupported by -fsanitize-kcfi-arity">;
211213
def err_drv_no_linker_llvm_support : Error<
@@ -478,6 +480,9 @@ def warn_ignoring_ftabstop_value : Warning<
478480
def warn_drv_overriding_option : Warning<
479481
"overriding '%0' option with '%1'">,
480482
InGroup<DiagGroup<"overriding-option">>;
483+
def warn_drv_overriding_deployment_version
484+
: Warning<"overriding deployment version from '%0' to '%1'">,
485+
InGroup<DiagGroup<"overriding-deployment-version">>;
481486
def warn_drv_treating_input_as_cxx : Warning<
482487
"treating '%0' input as '%1' when in C++ mode, this behavior is deprecated">,
483488
InGroup<Deprecated>;

0 commit comments

Comments
 (0)