Skip to content

Commit 8f56879

Browse files
committed
Rename test headers
1 parent c48b1ff commit 8f56879

File tree

1 file changed

+13
-12
lines changed

1 file changed

+13
-12
lines changed

clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -220,13 +220,13 @@ TEST(IncludeCleaner, ComputeMissingHeaders) {
220220
TEST(IncludeCleaner, GenerateMissingHeaderDiags) {
221221
Annotations MainFile(R"cpp(
222222
#include "a.h"
223-
#include "a_angled.h"
223+
#include "angled_wrapper.h"
224224
#include "all.h"
225225
$insert_b[[]]#include "baz.h"
226226
#include "dir/c.h"
227227
$insert_d[[]]$insert_foo[[]]#include "fuzz.h"
228228
#include "header.h"
229-
$insert_foobar[[]]$insert_b_angled[[]]#include <e.h>
229+
$insert_foobar[[]]$insert_angled[[]]#include <e.h>
230230
$insert_f[[]]$insert_vector[[]]
231231
232232
#define DEF(X) const Foo *X;
@@ -238,7 +238,7 @@ TEST(IncludeCleaner, GenerateMissingHeaderDiags) {
238238
239239
void foo() {
240240
$b[[b]]();
241-
$b_angled[[b_angled]]();
241+
$angled[[angled]]();
242242
243243
ns::$bar[[Bar]] bar;
244244
bar.d();
@@ -264,8 +264,10 @@ TEST(IncludeCleaner, GenerateMissingHeaderDiags) {
264264
TU.Filename = "main.cpp";
265265
TU.AdditionalFiles["a.h"] = guard("#include \"b.h\"");
266266
TU.AdditionalFiles["b.h"] = guard("void b();");
267-
TU.AdditionalFiles["a_angled.h"] = guard("#include \"b_angled.h\"");
268-
TU.AdditionalFiles["b_angled.h"] = guard("void b_angled();");
267+
268+
TU.AdditionalFiles["angled_wrapper.h"] = guard("#include <angled.h>");
269+
TU.AdditionalFiles["angled.h"] = guard("void angled();");
270+
TU.ExtraArgs.push_back("-I" + testPath("."));
269271

270272
TU.AdditionalFiles["dir/c.h"] = guard("#include \"d.h\"");
271273
TU.AdditionalFiles["dir/d.h"] =
@@ -305,7 +307,7 @@ TEST(IncludeCleaner, GenerateMissingHeaderDiags) {
305307
return Header.ends_with("buzz.h");
306308
}},
307309
/*AngledHeaders=*/{[](llvm::StringRef Header) {
308-
return Header.contains("b_angled.h");
310+
return Header.contains("angled.h");
309311
}});
310312
EXPECT_THAT(
311313
Diags,
@@ -315,12 +317,11 @@ TEST(IncludeCleaner, GenerateMissingHeaderDiags) {
315317
withFix({Fix(MainFile.range("insert_b"), "#include \"b.h\"\n",
316318
"#include \"b.h\""),
317319
FixMessage("add all missing includes")})),
318-
AllOf(
319-
Diag(MainFile.range("b_angled"),
320-
"No header providing \"b_angled\" is directly included"),
321-
withFix({Fix(MainFile.range("insert_b_angled"),
322-
"#include <b_angled.h>\n", "#include <b_angled.h>"),
323-
FixMessage("add all missing includes")})),
320+
AllOf(Diag(MainFile.range("angled"),
321+
"No header providing \"angled\" is directly included"),
322+
withFix({Fix(MainFile.range("insert_angled"),
323+
"#include <angled.h>\n", "#include <angled.h>"),
324+
FixMessage("add all missing includes")})),
324325
AllOf(Diag(MainFile.range("bar"),
325326
"No header providing \"ns::Bar\" is directly included"),
326327
withFix({Fix(MainFile.range("insert_d"),

0 commit comments

Comments
 (0)