[AsmPrinter] Simplify $local after D131429. NFC

MaskRay · web-flow · commit 34387fc63b5b · 2025-02-23T10:19:27.000-08:00
setType is unneeded (and AsmPrinter tries not to modify symbols). AsmPrinter. MCSA_ELF_TypeFunction is available on all targets using getSymbolPreferLocal. Pull Request: #128138
diff --git a/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp b/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
@@ -1084,11 +1084,9 @@ void AsmPrinter::emitFunctionEntryLabel() {
   if (TM.getTargetTriple().isOSBinFormatELF()) {
     MCSymbol *Sym = getSymbolPreferLocal(MF->getFunction());
     if (Sym != CurrentFnSym) {
-      cast<MCSymbolELF>(Sym)->setType(ELF::STT_FUNC);
       CurrentFnBeginLocal = Sym;
       OutStreamer->emitLabel(Sym);
-      if (MAI->hasDotTypeDotSizeDirective())
-        OutStreamer->emitSymbolAttribute(Sym, MCSA_ELF_TypeFunction);
+      OutStreamer->emitSymbolAttribute(Sym, MCSA_ELF_TypeFunction);
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -1084,11 +1084,9 @@ void AsmPrinter::emitFunctionEntryLabel() {`
`1084`	`1084`	`if (TM.getTargetTriple().isOSBinFormatELF()) {`
`1085`	`1085`	`MCSymbol *Sym = getSymbolPreferLocal(MF->getFunction());`
`1086`	`1086`	`if (Sym != CurrentFnSym) {`
`1087`		`- cast<MCSymbolELF>(Sym)->setType(ELF::STT_FUNC);`
`1088`	`1087`	`CurrentFnBeginLocal = Sym;`
`1089`	`1088`	`OutStreamer->emitLabel(Sym);`
`1090`		`- if (MAI->hasDotTypeDotSizeDirective())`
`1091`		`- OutStreamer->emitSymbolAttribute(Sym, MCSA_ELF_TypeFunction);`
	`1089`	`+ OutStreamer->emitSymbolAttribute(Sym, MCSA_ELF_TypeFunction);`
`1092`	`1090`	`}`
`1093`	`1091`	`}`
`1094`	`1092`	`}`