Skip to content

Commit 244df79

Browse files
committed
[InstCombine] Propagate FMF from select instead of fcmp
1 parent 94bcd9c commit 244df79

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3879,11 +3879,10 @@ Instruction *InstCombinerImpl::visitSelectInst(SelectInst &SI) {
38793879
// (X ugt Y) ? X : Y -> (X ole Y) ? Y : X
38803880
if (FCmp->hasOneUse() && FCmpInst::isUnordered(Pred)) {
38813881
FCmpInst::Predicate InvPred = FCmp->getInversePredicate();
3882-
// FIXME: The FMF should propagate from the select, not the fcmp.
38833882
Value *NewCond = Builder.CreateFCmpFMF(InvPred, Cmp0, Cmp1, FCmp,
38843883
FCmp->getName() + ".inv");
38853884
Value *NewSel =
3886-
Builder.CreateSelectFMF(NewCond, FalseVal, TrueVal, FCmp);
3885+
Builder.CreateSelectFMF(NewCond, FalseVal, TrueVal, &SI);
38873886
return replaceInstUsesWith(SI, NewSel);
38883887
}
38893888
}

0 commit comments

Comments
 (0)