Make prefix negate invocable

BUG: Type inference cannot find `-` when it is declared static because
it will thinks it needs to instantiate the enclosing nominal’s generic
parameter.

Author: CodaFi

Sources/LLVM/Constant.swift

@@ -126,26 +126,6 @@ public struct Constant<Repr: ConstantRepresentation>: IRValue {
     }
   }
 
-  /// Creates a constant negate operation to negate an integral value.
-  ///
-  /// - parameter lhs: The operand to negate.
-  ///
-  /// - returns: A constant value representing the negation of the given constant.
-  public static prefix func -(lhs: Constant<Signed>) -> Constant<Signed> {
-    precondition(lhs.repr == .signed, "Invalid representation")
-    return Constant<Signed>(llvm: LLVMConstNeg(lhs.llvm))
-  }
-
-  /// Creates a constant negate operation to negate a floating value.
-  ///
-  /// - parameter lhs: The operand to negate.
-  ///
-  /// - returns: A constant value representing the negation of the given constant.
-  public static prefix func -(lhs: Constant<Floating>) -> Constant<Floating> {
-    precondition(lhs.repr == .floating, "Invalid representation")
-    return Constant<Floating>(llvm: LLVMConstFNeg(lhs.llvm))
-  }
-
   /// Creates a constant add operation to add two homogenous constants together.
   ///
   /// - parameter lhs: The first summand value (the augend).
@@ -432,6 +412,26 @@ public struct Constant<Repr: ConstantRepresentation>: IRValue {
   }
 }
 
+/// Creates a constant negate operation to negate an integral value.
+///
+/// - parameter lhs: The operand to negate.
+///
+/// - returns: A constant value representing the negation of the given constant.
+public prefix func -(lhs: Constant<Signed>) -> Constant<Signed> {
+  precondition(lhs.repr == .signed, "Invalid representation")
+  return Constant<Signed>(llvm: LLVMConstNeg(lhs.llvm))
+}
+
+/// Creates a constant negate operation to negate a floating value.
+///
+/// - parameter lhs: The operand to negate.
+///
+/// - returns: A constant value representing the negation of the given constant.
+public prefix func -(lhs: Constant<Floating>) -> Constant<Floating> {
+  precondition(lhs.repr == .floating, "Invalid representation")
+  return Constant<Floating>(llvm: LLVMConstFNeg(lhs.llvm))
+}
+
 extension Constant where Repr: IntegralConstantRepresentation {
   // MARK: Logical Operations
 

Tests/LLVMTests/ConstantSpec.swift

@@ -26,9 +26,11 @@ class ConstantSpec : XCTestCase {
       let val2 = builder.buildSub(constant - constant, constant / constant)
       // SIGNEDCONST-NOT: %{{[0-9]+}} = mul i64 %%{{[0-9]+}}, %%{{[0-9]+}}
       let val3 = builder.buildMul(val1, val2)
+      // SIGNEDCONST-NOT: %{{[0-9]+}} = mul i64 %%{{[0-9]+}}, %%{{[0-9]+}}
+      let val4 = builder.buildMul(val3, -constant)
 
-      // SIGNEDCONST-NEXT: ret i64 -1848
-      builder.buildRet(val3)
+      // SIGNEDCONST-NEXT: ret i64 77616
+      builder.buildRet(val4)
       // SIGNEDCONST-NEXT: }
       module.dump()
     })