From b270eaf8a27a2f3b96710498c1b005e97de577b0 Mon Sep 17 00:00:00 2001 From: Jason Teng Date: Sun, 6 Aug 2023 23:11:03 -0700 Subject: [PATCH 1/3] Add: password restriction match to db image manual per linuxserver/mariadb/, the required DATABASE_PASSWORD must > 4 --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 10752b2..8e6d255 100644 --- a/README.md +++ b/README.md @@ -173,7 +173,7 @@ Container images are configured using parameters passed at runtime (such as thos | `-e DB_HOST=` | for specifying the database host | | `-e DB_PORT=` | for specifying the database port if not default 3306 | | `-e DB_USER=` | for specifying the database user | -| `-e DB_PASS=` | for specifying the database password (non-alphanumeric passwords must be properly escaped.) | +| `-e DB_PASS=` | for specifying the database password (minimum 4 characters & non-alphanumeric passwords must be properly escaped.) | | `-e DB_DATABASE=bookstackapp` | for specifying the database to be used | | `-v /config` | this will store any uploaded data on the docker host | From bb3a6b4f05379c5d64d0bed070910fc440e551a6 Mon Sep 17 00:00:00 2001 From: Jason Teng Date: Sun, 6 Aug 2023 23:30:33 -0700 Subject: [PATCH 2/3] Revert "Add: password restriction match to db image manual" This reverts commit b270eaf8a27a2f3b96710498c1b005e97de577b0. --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 8e6d255..10752b2 100644 --- a/README.md +++ b/README.md @@ -173,7 +173,7 @@ Container images are configured using parameters passed at runtime (such as thos | `-e DB_HOST=` | for specifying the database host | | `-e DB_PORT=` | for specifying the database port if not default 3306 | | `-e DB_USER=` | for specifying the database user | -| `-e DB_PASS=` | for specifying the database password (minimum 4 characters & non-alphanumeric passwords must be properly escaped.) | +| `-e DB_PASS=` | for specifying the database password (non-alphanumeric passwords must be properly escaped.) | | `-e DB_DATABASE=bookstackapp` | for specifying the database to be used | | `-v /config` | this will store any uploaded data on the docker host | From 51c954c18b9fe9559eb43dbe554d856c09493528 Mon Sep 17 00:00:00 2001 From: Jason Teng Date: Sun, 6 Aug 2023 23:32:53 -0700 Subject: [PATCH 3/3] Edit: moving change to readme-vars.yml --- readme-vars.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/readme-vars.yml b/readme-vars.yml index 06ab3a9..25a6ea8 100644 --- a/readme-vars.yml +++ b/readme-vars.yml @@ -29,7 +29,7 @@ param_env_vars: - { env_var: "DB_HOST", env_value: "", desc: "for specifying the database host" } - { env_var: "DB_PORT", env_value: "", desc: "for specifying the database port if not default 3306" } - { env_var: "DB_USER", env_value: "", desc: "for specifying the database user" } - - { env_var: "DB_PASS", env_value: "", desc: "for specifying the database password (non-alphanumeric passwords must be properly escaped.)" } + - { env_var: "DB_PASS", env_value: "", desc: "for specifying the database password (minimum 4 characters & non-alphanumeric passwords must be properly escaped.)" } - { env_var: "DB_DATABASE", env_value: "bookstackapp", desc: "for specifying the database to be used" } param_usage_include_ports: true