changed appkey usage, moved appurl if, updated readme vars

Author: homerr

readme-vars.yml

@@ -30,7 +30,6 @@ param_env_vars:
   - { env_var: "DB_PASS", env_value: "<yourdbpass>", desc: "for specifying the database password" }
   - { env_var: "DB_DATABASE", env_value: "bookstackapp", desc: "for specifying the database to be used" }
   - { env_var: "APPURL", env_value: "your.site.here.xyz", desc: "for specifying the url your application will be accessed on "}
-  - { env_var: "ADVANCED_MODE", env_value: "1", desc: "enables advanced mode for direct editing of the .env - scroll down for details on this"}
 
 param_usage_include_ports: true
 param_ports:
@@ -63,19 +62,18 @@ app_setup_block: |
 
   Documentation can be found at https://www.bookstackapp.com/docs/
 
-  ### Advanced Mode
-  We have implemented a special 'advanced mode' where users who wish to leverage the built in SMTP or LDAP functionality, will have the ability to edit the .env by hand. With `ADVANCED_MODE=1` set when
-  the container is created, it will copy the .env.example to /config within the container. You can then edit this file on the host system (make sure you read the BookStack docs) and restart the 
-  container when finished. When the container starts, it copies /config/.env to /var/www/html/.env within the container for the web app to use. It will do this every time the container restarts. 
-  
-  Note, the APP_KEY is still set by PHP environment so you do not need to worrry about this. 
+  ### Advanced Users
+  If you wish to use the extra functionality of BookStack such as email, memcache, ldap and so on you will need to make your own .env file with guidance from the BookStack documentation.
+
+  When you create the container, do not set any arguements for SQL or APPURL. The container will copy an .env file to /config/www/.env on your host system for you to edit. 
 
   ### Composer
 
   Some simple docker-compose files are included for you to get started with. You will still need to manually configure the SQL server, but the compose files will get the stack running for you. 
 
 # changelog
 changelogs:
+  - { date: "15.10.18:", desc: "Changed functionality for advanced users"}
   - { date: "08.10.18:", desc: "Advanced mode, symlink changes, sed fixing, docs updated, added some composer files"}
   - { date: "23.09.28:", desc: "Updates pre-release"}
   - { date: "02.07.18:", desc: "Initial Release." }

root/etc/cont-init.d/50-config

@@ -22,6 +22,19 @@ do
 [[ ! -L "$i" ]] && ln -s /config/www/"$(basename "$i")" "$i"
 done
 
+# Create API key if needed
+if [ ! -f "/config/BOOKSTACK_APP_KEY.txt" ];
+	then
+	echo "Generating BookStack app key for first run"
+	key=$(php /var/www/html/artisan key:generate --show | tr -d '//' )
+	echo $key > /config/BOOKSTACK_APP_KEY.txt
+	echo "App Key set to $key you can modify the file to update /config/BOOKSTACK_APP_KEY.txt"
+elif [ -f "/config/BOOKSTACK_APP_KEY.txt" ];
+	then
+	echo "App Key found - setting variable for seds"
+	key=$(cat /config/BOOKSTACK_APP_KEY.txt)
+fi
+
 # .env file setup
 # check to see if db_user is set, if it is then run seds and if not then leave them
 if [ "${DB_USER}" ];
@@ -32,20 +45,10 @@ if [ "${DB_USER}" ];
 	sed -i "s/DB_DATABASE=database_database/DB_DATABASE=${DB_DATABASE}/g" /config/www/.env
 	sed -i "s/DB_USERNAME=database_username/DB_USERNAME=${DB_USER}/g" /config/www/.env
 	sed -i "s/DB_PASSWORD=database_user_password/DB_PASSWORD=${DB_PASS}/g" /config/www/.env
-elif [ "${APP_URL}" ];
-	then
-	echo "App URL Set"
-	sed -i "s,#\sAPP_URL.*,APP_URL=${APP_URL},g" /config/www/.env
 fi
 
-# Create API key if needed
-if [ ! -f "/config/BOOKSTACK_APP_KEY.txt" ]
-	then
-	echo "Generating BookStack app key for first run"
-	key=$(php /var/www/html/artisan key:generate --show | tr -d '//' )
-	echo $key > /config/BOOKSTACK_APP_KEY.txt
-	echo "App Key set to $key you can modify the file to update /config/BOOKSTACK_APP_KEY.txt"
-fi
+# set appurl if detected
+[[ "${APP_URL}" ]] && sed -i "s,#\sAPP_URL.*,APP_URL=${APP_URL},g" /config/www/.env
 
 # update database - will set up database if fresh, or, migrate existing
 php /var/www/html/artisan migrate --force

root/etc/services.d/php-fpm/run

@@ -1,3 +1,2 @@
 #!/usr/bin/with-contenv bash
-export APP_KEY=$(cat /config/BOOKSTACK_APP_KEY.txt)
 exec /usr/sbin/php-fpm7 -F