This repository was archived by the owner on Feb 23, 2021. It is now read-only.
Fix lnd safe shutdown. #1134
Closed
Fix lnd safe shutdown. #1134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnd needs to be able to shutdown fully, and currently because it's a child process of the main node process, it is killed when the app is killed and isn't given a chance to fully tear down. Now, we start lnd as a detached process that can die at its own pace when the app is closed. A potential downside is that the lnd logs no longer appear alongside the app logs. However, the lnd logs are still accessible in the app's data directory.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lnd needs to be able to shutdown fully, and currently because it's a child process
of the main node process, it is killed when the app is killed and isn't given a
chance to fully tear down. Now, we start lnd as a detached process that can die
at its own pace when the app is closed.
A potential downside is that the lnd logs no longer appear alongside the app logs.
However, the lnd logs are still accessible in the app's data directory.
Depends on #1136. Closes #802.