@@ -2312,8 +2312,9 @@ where
2312
2312
/// public, and thus should be called whenever the result is going to be passed out in a
2313
2313
/// [`MessageSendEvent::BroadcastChannelUpdate`] event.
2314
2314
///
2315
- /// Note that this function may be called without the `peer_state` corresponding to the passed
2316
- /// channel's counterparty acquired, when the call site has full ownership of the channel.
2315
+ /// Note that in `internal_closing_signed`, this function is called without the `peer_state`
2316
+ /// corresponding to the channel's counterparty locked, as the channel been removed from the
2317
+ /// storage and the `peer_state` lock has been dropped.
2317
2318
fn get_channel_update_for_broadcast ( & self , chan : & Channel < <SP :: Target as SignerProvider >:: Signer > ) -> Result < msgs:: ChannelUpdate , LightningError > {
2318
2319
if !chan. should_announce ( ) {
2319
2320
return Err ( LightningError {
@@ -2332,8 +2333,10 @@ where
2332
2333
/// is public (only returning an Err if the channel does not yet have an assigned short_id),
2333
2334
/// and thus MUST NOT be called unless the recipient of the resulting message has already
2334
2335
/// provided evidence that they know about the existence of the channel.
2335
- /// Note that this function may be called without the `peer_state` corresponding to the passed
2336
- /// channel's counterparty acquired, when the call site has full ownership of the channel.
2336
+ ///
2337
+ /// Note that through `internal_closing_signed`, this function is called without the
2338
+ /// `peer_state` corresponding to the channel's counterparty locked, as the channel been
2339
+ /// removed from the storage and the `peer_state` lock has been dropped.
2337
2340
fn get_channel_update_for_unicast ( & self , chan : & Channel < <SP :: Target as SignerProvider >:: Signer > ) -> Result < msgs:: ChannelUpdate , LightningError > {
2338
2341
log_trace ! ( self . logger, "Attempting to generate channel update for channel {}" , log_bytes!( chan. channel_id( ) ) ) ;
2339
2342
let short_channel_id = match chan. get_short_channel_id ( ) . or ( chan. latest_inbound_scid_alias ( ) ) {
0 commit comments