f moar test

Author: TheBlueMatt

lightning/src/ln/payment_tests.rs

@@ -2756,9 +2756,9 @@ fn do_no_missing_sent_on_midpoint_reload(persist_manager_with_payment: bool) {
 	let chanmon_cfgs = create_chanmon_cfgs(2);
 	let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 	let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
-	let (persister_a, persister_b);
-	let (chain_monitor_a, chain_monitor_b);
-	let (nodes_0_deserialized, nodes_0_deserialized_b);
+	let (persister_a, persister_b, persister_c);
+	let (chain_monitor_a, chain_monitor_b, chain_monitor_c);
+	let (nodes_0_deserialized, nodes_0_deserialized_b, nodes_0_deserialized_c);
 	let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 
 	let chan_id = create_announced_chan_between_nodes(&nodes, 0, 1).2;
@@ -2794,6 +2794,8 @@ fn do_no_missing_sent_on_midpoint_reload(persist_manager_with_payment: bool) {
 	if let Event::PaymentSent { payment_preimage, .. } = events[1] { assert_eq!(payment_preimage, our_payment_preimage); } else { panic!(); }
 	// Note that we don't get a PaymentPathSuccessful here as we leave the HTLC pending to avoid
 	// the double-claim that would otherwise appear at the end of this test.
+	let as_broadcasted_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().split_off(0);
+	assert_eq!(as_broadcasted_txn.len(), 1);
 
 	// Ensure that, even after some time, if we restart we still include *something* in the current
 	// `ChannelManager` which prevents a `PaymentFailed` when we restart even if pending resolved
@@ -2806,6 +2808,19 @@ fn do_no_missing_sent_on_midpoint_reload(persist_manager_with_payment: bool) {
 	reload_node!(nodes[0], test_default_channel_config(), &nodes[0].node.encode(), &[&chan_0_monitor_serialized], persister_b, chain_monitor_b, nodes_0_deserialized_b);
 	let events = nodes[0].node.get_and_clear_pending_events();
 	assert!(events.is_empty());
+
+	// Ensure that we don't generate any further events even after the channel-closing commitment
+	// transaction is confirmed on-chain.
+	confirm_transaction(&nodes[0], &as_broadcasted_txn[0]);
+	for _ in 0..(IDEMPOTENCY_TIMEOUT_TICKS * 2) { nodes[0].node.timer_tick_occurred(); }
+
+	let events = nodes[0].node.get_and_clear_pending_events();
+	assert!(events.is_empty());
+
+	let chan_0_monitor_serialized = get_monitor!(nodes[0], chan_id).encode();
+	reload_node!(nodes[0], test_default_channel_config(), &nodes[0].node.encode(), &[&chan_0_monitor_serialized], persister_c, chain_monitor_c, nodes_0_deserialized_c);
+	let events = nodes[0].node.get_and_clear_pending_events();
+	assert!(events.is_empty());
 }
 
 #[test]