Skip to content

Commit 70e4001

Browse files
committed
Reserve async signing related channel TLV types
A LDK user deployed to production a WIP version of the async signing branch in which two new TLVs were added to channel. To prevent them from needing to perform a migration, we can just new types for TLVs that have yet to be included in a release. A note has been added to ensure types 45 and 47 are not used for another purpose.
1 parent 51926f1 commit 70e4001

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

lightning/src/ln/channel.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8726,7 +8726,8 @@ impl<SP: Deref> Writeable for Channel<SP> where SP::Target: SignerProvider {
87268726
(39, pending_outbound_blinding_points, optional_vec),
87278727
(41, holding_cell_blinding_points, optional_vec),
87288728
(43, malformed_htlcs, optional_vec), // Added in 0.0.119
8729-
(45, self.context.local_initiated_shutdown, option), // Added in 0.0.122
8729+
// 45 and 47 are reserved for async signing
8730+
(49, self.context.local_initiated_shutdown, option), // Added in 0.0.122
87308731
});
87318732

87328733
Ok(())
@@ -9066,7 +9067,8 @@ impl<'a, 'b, 'c, ES: Deref, SP: Deref> ReadableArgs<(&'a ES, &'b SP, u32, &'c Ch
90669067
(39, pending_outbound_blinding_points_opt, optional_vec),
90679068
(41, holding_cell_blinding_points_opt, optional_vec),
90689069
(43, malformed_htlcs, optional_vec), // Added in 0.0.119
9069-
(45, local_initiated_shutdown, option),
9070+
// 45 and 47 are reserved for async signing
9071+
(49, local_initiated_shutdown, option),
90709072
});
90719073

90729074
let (channel_keys_id, holder_signer) = if let Some(channel_keys_id) = channel_keys_id {

0 commit comments

Comments
 (0)