f don't set scid as previously failed on invalid route

Author: valentinewallace

lightning/src/ln/outbound_payment.rs

@@ -710,15 +710,19 @@ impl OutboundPayments {
 		debug_assert_eq!(paths.len(), path_results.len());
 		for (path, path_res) in paths.into_iter().zip(path_results) {
 			if let Err(e) = path_res {
-				let scid = path[0].short_channel_id;
+				let failed_scid = if let APIError::InvalidRoute { .. } = e {
+					None
+				} else {
+					Some(path[0].short_channel_id)
+				};
 				events.push(events::Event::PaymentPathFailed {
 					payment_id: Some(payment_id),
 					payment_hash,
 					payment_failed_permanently: false,
 					network_update: None,
 					all_paths_failed: false,
 					path,
-					short_channel_id: if let APIError::InvalidRoute { .. } = e { None } else { Some(scid) },
+					short_channel_id: failed_scid,
 					retry: None,
 					#[cfg(test)]
 					error_code: None,