From c3d83fa97b25acb79653c92622410289677ec008 Mon Sep 17 00:00:00 2001 From: John Cupitt Date: Tue, 1 Nov 2022 12:36:01 +0000 Subject: [PATCH] remove error_buffer_copy We had a stray declaration of vips_error_buffer_copy() in FFI.php. This would prevent php-vips starting with libvips before 8.9. Thanks Waschnick. see https://github.com/libvips/php-vips/issues/162 --- CHANGELOG.md | 5 +++++ README.md | 2 +- src/FFI.php | 1 - 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index bfe47c7..580cfe4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,11 @@ All notable changes to `:vips` will be documented in this file. +## master + +- remove unused vips_error_buffer_copy() declaration to fix compatibility with + libvips before 8.9 [Waschnick] + ## 2.1.0 - 2022-10-11 - allow "-" as a name component separator [andrews05] diff --git a/README.md b/README.md index a091cf7..4089894 100644 --- a/README.md +++ b/README.md @@ -48,7 +48,7 @@ to your `composer.json`: php-vips does not yet support preloading, so you need to enable FFI globally. This has some security implications, since anyone who can run php on your -server can use it to make calls off into any native library they can find. +server can use it to call any native library they have access to. Of course if attackers are running their own PHP code on your webserver you are probably already toast, unfortunately. diff --git a/src/FFI.php b/src/FFI.php index 6db84ff..d46497b 100644 --- a/src/FFI.php +++ b/src/FFI.php @@ -436,7 +436,6 @@ private static function init(): void int vips_shutdown (void); const char *vips_error_buffer (void); -char *vips_error_buffer_copy (void); void vips_error_clear (void); void vips_error_freeze (void); void vips_error_thaw (void);