Skip to content

Commit c388e68

Browse files
authored
remove error_buffer_copy (#163)
We had a stray declaration of vips_error_buffer_copy() in FFI.php. This would prevent php-vips starting with libvips before 8.9. Thanks Waschnick. see #162
1 parent 57983ad commit c388e68

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ All notable changes to `:vips` will be documented in this file.
44

55
## master
66

7+
- remove unused vips_error_buffer_copy() declaration to fix compatibility with
8+
libvips before 8.9 [Waschnick]
79
- refactor callBase() for maintainability
810
- work around a php-ffi memory leak in getPspec() [levmv]
911
- work around a php-ffi memory leak in arrayType()

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ to your `composer.json`:
4848

4949
php-vips does not yet support preloading, so you need to enable FFI globally.
5050
This has some security implications, since anyone who can run php on your
51-
server can use it to make calls off into any native library they can find.
51+
server can use it to call any native library they have access to.
5252

5353
Of course if attackers are running their own PHP code on your webserver you
5454
are probably already toast, unfortunately.

src/FFI.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -443,7 +443,6 @@ private static function init(): void
443443
int vips_shutdown (void);
444444
445445
const char *vips_error_buffer (void);
446-
char *vips_error_buffer_copy (void);
447446
void vips_error_clear (void);
448447
void vips_error_freeze (void);
449448
void vips_error_thaw (void);

0 commit comments

Comments
 (0)