Index.add raise TypeError on unexpected type

Instead of AttributeError

Author: jdavid

CHANGELOG.rst

@@ -1,3 +1,16 @@
+1.5.0 (UNRELEASED)
+-------------------------
+
+- Fix truncated diff when there are nulls
+  `#1047 <https://github.com/libgit2/pygit2/pull/1047>`_
+  `#1043 <https://github.com/libgit2/pygit2/issues/1043>`_
+
+Breaking changes:
+
+- Fix ``Index.add(...)`` raise ``TypeError`` instead of ``AttributeError`` when
+  arguments are of unexpected type
+
+
 1.4.0 (2020-11-06)
 -------------------------
 

docs/recipes.rst

@@ -1,5 +1,5 @@
 **********************************************************************
-pygit2 Recipes
+Recipes
 **********************************************************************
 
 A list of some standard git commands and their pygit2 equivalents. This

pygit2/index.py

@@ -199,7 +199,6 @@ def add(self, path_or_entry):
         If an IndexEntry is given, that entry will be added or update in the
         Index without checking for the existence of the path or id.
         """
-
         if isinstance(path_or_entry, IndexEntry):
             entry = path_or_entry
             centry, str_ref = entry._to_c()
@@ -208,7 +207,7 @@ def add(self, path_or_entry):
             path = path_or_entry
             err = C.git_index_add_bypath(self._index, to_bytes(path))
         else:
-            raise AttributeError('argument must be string or IndexEntry')
+            raise TypeError('argument must be string or IndexEntry')
 
         check_error(err, io=True)