Skip to content

Commit fee5414

Browse files
committed
Revise test workaround comments
1 parent 0620c68 commit fee5414

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

LibGit2Sharp.Tests/RepositoryFixture.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,8 +167,8 @@ private static void CheckGitConfigFile(string dir)
167167

168168
private static void AssertIsHidden(string repoPath)
169169
{
170-
//Work around .NET Core handling calls to File.GetAttributes with paths with a trailing slash differently
171-
//without removing the trailing slash, the Hidden attribute is not included.
170+
//Workaround for .NET Core 1.x never considering a directory hidden if the path has a trailing slash
171+
//https://github.com/dotnet/corefx/issues/18520
172172
repoPath = repoPath.TrimEnd('/');
173173

174174
FileAttributes attribs = File.GetAttributes(repoPath);

LibGit2Sharp.Tests/TestHelpers/BaseFixture.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,8 @@ protected static string Touch(string parent, string file, string content = null,
389389

390390
File.WriteAllText(filePath, content ?? string.Empty, encoding ?? Encoding.ASCII);
391391

392-
//Work around .NET Core 1.x behavior where all newly created files have execute permissions set.
392+
//Workaround for .NET Core 1.x behavior where all newly created files have execute permissions set.
393+
//https://github.com/dotnet/corefx/issues/13342
393394
if (Constants.IsRunningOnUnix && newFile)
394395
{
395396
RemoveExecutePermissions(filePath, newFile);
@@ -417,6 +418,7 @@ protected static string Touch(string parent, string file, Stream stream)
417418
}
418419

419420
//Work around .NET Core 1.x behavior where all newly created files have execute permissions set.
421+
//https://github.com/dotnet/corefx/issues/13342
420422
if (Constants.IsRunningOnUnix && newFile)
421423
{
422424
RemoveExecutePermissions(filePath, newFile);

0 commit comments

Comments
 (0)