Rebase operations in a bare repository should throw

Author: jamill

LibGit2Sharp.Tests/RebaseFixture.cs

@@ -539,6 +539,21 @@ public void CanRebaseHandlePatchAlreadyApplied()
             }
         }
 
+        [Fact]
+        public void RebasingInBareRepositoryThrows()
+        {
+            string path = SandboxBareTestRepo();
+            using (var repo = new Repository(path))
+            {
+                Branch rebaseUpstreamBranch = repo.Branches["refs/heads/test"];
+
+                Assert.NotNull(rebaseUpstreamBranch);
+                Assert.Throws<BareRepositoryException>(() => repo.Rebase.Start(null, rebaseUpstreamBranch, null, Constants.Identity, new RebaseOptions()));
+                Assert.Throws<BareRepositoryException>(() => repo.Rebase.Continue(Constants.Identity, new RebaseOptions()));
+                Assert.Throws<BareRepositoryException>(() => repo.Rebase.Abort());
+            }
+        }
+
         private void ConstructRebaseTestRepository(Repository repo)
         {
             // Constructs a graph that looks like:

LibGit2Sharp/Rebase.cs

@@ -79,6 +79,8 @@ public virtual RebaseResult Start(Branch branch, Branch upstream, Branch onto, I
 
             options = options ?? new RebaseOptions();
 
+            EnsureNonBareRepo();
+
             if (this.repository.Info.CurrentOperation != CurrentOperation.None)
             {
                 throw new LibGit2SharpException(string.Format(
@@ -140,6 +142,8 @@ public virtual RebaseResult Continue(Identity committer, RebaseOptions options)
 
             options = options ?? new RebaseOptions();
 
+            EnsureNonBareRepo();
+
             using (GitCheckoutOptsWrapper checkoutOptionsWrapper = new GitCheckoutOptsWrapper(options))
             {
                 GitRebaseOptions gitRebaseOptions = new GitRebaseOptions()
@@ -201,6 +205,8 @@ public virtual void Abort(RebaseOptions options)
         {
             options = options ?? new RebaseOptions();
 
+            EnsureNonBareRepo();
+
             using (GitCheckoutOptsWrapper checkoutOptionsWrapper = new GitCheckoutOptsWrapper(options))
             {
                 GitRebaseOptions gitRebaseOptions = new GitRebaseOptions()
@@ -243,5 +249,13 @@ public virtual RebaseStepInfo GetCurrentStepInfo()
                 return stepInfo;
             }
         }
+
+        private void EnsureNonBareRepo()
+        {
+            if (this.repository.Info.IsBare)
+            {
+                throw new BareRepositoryException("Rebase operations in a bare repository are not supported.");
+            }
+        }
     }
 }